| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 24 Aug 2025 21:30:06 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=436.801773,conversation_content-fragment;desc="conversation_content fragment";dur=741.702624,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=456.881767,nginx;desc="NGINX";dur=0.871045,glb;desc="GLB";dur=96.740048
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 2477dc8
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=9GDB4Ckfw4wR2nBr%2BeAyOpepmjItK0OYyOiMFWyExWZu%2B4J%2B0%2BDbEsM8Yph91%2FTqJ4eXrRpOIPkkPZJyBnJ1rBcnxNYZrlZJiJE0dnqA9WgMhRtVHOSEQIANMIUGHy6WsPuxZdAmwgeEH1hGOMJ6KILmPsKQPLYP7e4eSgT2u063VVpnqV9FRgNfeZJ2J77RWU%2FcWBVnCnBxYjFNBRmcA6iQ%2BL1T1WnYbDVKMxZ9vVJ7PVzi9pA64By1yMf0kAKO4puQV3CxxlQlFYloWZyz1A%3D%3D--DnjcL6nw4LA0LR3k--u6LnsU%2BjnvpSD860%2BCSDPQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1623086239.1756071005; Path=/; Domain=github.com; Expires=Mon, 24 Aug 2026 21:30:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 24 Aug 2026 21:30:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D40C:1CAE2B:1227F09:17D0CDF:68AB845D
Implement P3223R2 Making `istream::ignore()` Less Surprising by frederick-vs-ja · Pull Request #5604 · microsoft/STL · GitHub
Implement P3223R2 Making
frederick-vs-ja
changed the title
Implement P3223R2 Making
Implement P3223R2 Making Jun 23, 2025
frederick-vs-ja
changed the title
Implement P3223R2 Making
Implement P3223R2 Making Jun 23, 2025
github-project-automation
bot
moved this from Initial Review
to Done
in STL Code Reviews
Jun 23, 2025
github-project-automation
bot
moved this from Done
to Initial Review
in STL Code Reviews
Jun 23, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement P3223R2 Making istream::ignore() Less Surprising
#5604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
changed the title
std::istream::ignore Less Surprisingstd::istream::ignore() Less Surprising
frederick-vs-ja
changed the title
std::istream::ignore() Less Surprisingistream::ignore() Less Surprising
github-project-automation
bot
moved this from Initial Review
to Done
in STL Code Reviews
github-project-automation
bot
moved this from Done
to Initial Review
in STL Code Reviews
|
@frederick-vs-ja (This is not a review. Just a couple of questions.) Was the paper voted in as DR? I guess not. My reading of the Standard is that resolving the ambiguity is not required is that so? |
I guess not, either. But according to the paper issue I think it should be treated as a DR.
Yes. In this PR the ambiguity is resolved "by accident", which is a consequence of backporting. I don't think the ambiguity resolution is disallowed, either. |
StephanTLavavej
approved these changes
Aug 6, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🐱 😸 🐈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
As a Defect Report against old standard modes. Fixes #5618.
As a result of DR-backing P3223R2, the new overload is templated, and thus this PR happens to "constrain the new overload to prevent ambiguities" and keeps
in.ignore(100, -1L)well-formed.