CARVIEW |
Select Language
HTTP/2 200
date: Sun, 24 Aug 2025 00:47:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=630.558459,conversation_content-fragment;desc="conversation_content fragment";dur=669.082308,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=625.257889,nginx;desc="NGINX";dur=1.231485,glb;desc="GLB";dur=96.561574
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 2477dc8
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=f0T5YmIrcJr4eBbyfjUHzDKM5FFtMi6hGG3bW8LdULLKvLRq2K7jSY9C%2F0VsasrXSwE7PQ2H65I%2Bc%2B7Lw8uKJF%2FUlWXOtclczRKcS%2FYcUh0uEkibTiSXYf1HyTg8lL8y%2FvpnOCtnlRQS8ojHPm3A2x84sa2sO%2FIi2rBdjQBcv2EbCIT%2BxBWcMhe3IOwFrFGKXXeSSGD%2BzQ6C%2FN4IjDooVYhWjaj4TlRwbftNI5KKU8hN17nGcm%2Bi%2BM5KJA4eLPGm4ynbzWRfcdMLMwLlNHG91g%3D%3D--x82b0amxJAR62%2FYU--0obJqk%2BTAj3oKwdsxATCdg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.441314340.1755996456; Path=/; Domain=github.com; Expires=Mon, 24 Aug 2026 00:47:36 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 24 Aug 2026 00:47:36 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 94E8:22E553:A03EC9:D30B24:68AA6128
`<regex>`: Use `std::search()` in skip heuristic by muellerj2 Β· Pull Request #5586 Β· microsoft/STL Β· GitHub
StephanTLavavej
added
performance
Must go faster
regex
meow is a substring of homeowner
labels
Jun 14, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<regex>
: Use std::search()
in skip heuristic
#5586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-skip-using-std-search
Aug 8, 2025
Merged
<regex>
: Use std::search()
in skip heuristic
#5586
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-skip-using-std-search
Aug 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Aug 2, 2025
Thanks, looks great! π» |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks again for figuring out how to make this faster! π π¦ π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
Towards #5468. This replaces the weird usage of
_Cmp_chrange()
by a straightforward call tostd::search()
in_Matcher2::_Skip()
.I fix a copy-paste mistake in the comment describing
_Cmp_icase_translateleft
as well.I also made an attempt to replace
_Cmp_chrange()
's implementation by a straightforward call tostd::mismatch()
, but that seems to be a pessimization in practice of about 10 % (probably because the strings tend to be quite short).There will still be one follow-up to make an obvious improvement to the skip heuristic for
regex
andwregex
incollate
mode. But otherwise, I think this is basically it for simple improvements to the skip heuristic. There are still a few opportunities that could lead to some improvement -- handling several branches, avoiding to walk the NFA for each_Skip()
call, or avoiding to compare the NFA nodes matched by_Skip()
in_Match_pat()
again -- but they are not straightforward to implement.Benchmark
Note that this means that all improvements since #5509 have sped up searching for the regex
(bibe)+
by a factor of about 450 and for(?:bibe)+
by a factor of about 1000 in this benchmark.