CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:23:06 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=354.976321,conversation_content-fragment;desc="conversation_content fragment";dur=828.136166,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=449.532956,nginx;desc="NGINX";dur=1.422695,glb;desc="GLB";dur=102.641618
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=YlR9%2F96bJzBzx1HrvyDVEGT1%2FFShIAqyhBTqzo8sT9XhK8Qec49MoEggEhENwJcE5V1npsNjN%2B7qYcSAoFk5Mrak%2BoulehCl3gFCvonRC%2FSvJuVoPBucJu%2Bx%2BWiiBd7iqLQ1BNzHbnEeOJgpu6k8uhcT7smZhmNlLsI1GAOAX5k0aAdmDEZ69COJVa2OHR3hYa3aMpnyAZliiiRuXw7FsARjftwhK5Tgj0mgjRgQs8%2BDcf%2FgaYa1boBPW%2Fs54HRn5aLz8bPp6BMYyGzOGH75Yg%3D%3D--cdf1cLTnz3nnZ2kU--%2BL17G6%2B5nqaC4GbSAKsixA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1120164578.1753298585; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:23:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:23:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AF3A:36F97A:1048AD5:1349469:68813699
`<regex>`: Avoid generating unnecessary single-branch `_N_if` nodes by muellerj2 ยท Pull Request #5539 ยท microsoft/STL ยท GitHub
muellerj2
force-pushed
the
regex-avoid-generating-single-branch-ifs
branch
from
May 24, 2025 13:00
StephanTLavavej
added
performance
Must go faster
regex
meow is a substring of homeowner
labels
May 27, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<regex>
: Avoid generating unnecessary single-branch _N_if
nodes
#5539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-avoid-generating-single-branch-ifs
May 28, 2025
Merged
<regex>
: Avoid generating unnecessary single-branch _N_if
nodes
#5539
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-avoid-generating-single-branch-ifs
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8314d2a
to
db37000
Compare
StephanTLavavej
approved these changes
May 28, 2025
case _N_capture: | ||
// TRANSITION, requires more research to decide on the subset of loops that we can make simple: | ||
// - Simple mode can square the running time when matching a regex to an input string in the current matcher | ||
// - The optimal subset of simple loops for a non-recursive rewrite of the matcher aren't clear yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should say "The optimal subset ... isn't clear yet" but it isn't worth resetting testing.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
๐ โฑ๏ธ ๐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canโt perform that action at this time.
The parser likes to generate single-branch
_N_if
nodes in the NFA for no good reason. These nodes have a noticeable runtime cost in the matcher. This PR avoids generating these nodes.This change has side effects:
error_stack
exception before will match successfully after this PR._Matcher2::_Do_rep()
calls can now take the place previously occupied by recursive calls of_Matcher2::_Do_if()
._Matcher2::_Do_rep()
takes more bytes from the stack (I didn't check recently, but I remember it was about 100 bytes per call?), so there will be a very small set of input strings that will run into an actual stack overflow now instead of anerror_stack
exception.Without further changes, there would be more side effects because some loops would get classified as simple now. However, I preempted this reclassification by adjusting
_Parser2::_Calculate_loop_simplicity()
. There are two reasons for this.error_stack
exception before, and it's more important to make more regexes resistant against stack overflow. For example, if we were to allow the reclassification, this would fix the stack overflow for the regex in <regex>: Grouping within repetition causes regex stack errorย #997.I added no new tests because (a) there is no obvious additional set of regexes to test and (b) this change affects the generated NFAs for all regexes without exception (all of them contained at least one single-branch
_N_if
node before), so the whole existing test suite serves as test coverage for this change.Benchmark