CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:23:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=384.048728,conversation_content-fragment;desc="conversation_content fragment";dur=750.965834,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=337.471685,nginx;desc="NGINX";dur=0.703529,glb;desc="GLB";dur=101.543479
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=fUNZkQaB4sV%2F0s5uEM5XEExEjo6dBn8rn%2BCV97aYm0ClM5v%2BhmqImntraExG7sI1%2BPWLj3LbwuQQIOxR6%2BOblTj7sNaaKNBGYhkmvbK8BGaPwRwPaXcwhW9odCD0UPKY%2Bm%2BG8Oje24e9DZAlnD099nOGopeDiFm%2FZB41EKRn5M%2FTYEHz7GQHZ50axt%2B9lRp13v6pTfNaru0%2BwAYTprCPMiS9uFnWOM5qPSezHumTWzUKIQZQwaBWRXtQ6Brp3jiPREES9gyTYVaqRP723V%2BNyw%3D%3D--9pWnAS8BU3pXVCJq--aVK%2Fa0M60Jq6C1AXgnhEdw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.511708684.1753298637; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:23:57 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:23:57 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D60C:256CA9:103132C:1331FAE:688136CD
`<regex>`: Add multiline option and make non-multiline mode the default by muellerj2 Β· Pull Request #5535 Β· microsoft/STL Β· GitHub
muellerj2
force-pushed
the
regex-implement-multiline-option
branch
from
May 23, 2025 21:55
muellerj2
force-pushed
the
regex-implement-multiline-option
branch
from
May 23, 2025 21:57
StephanTLavavej
added
LWG
Library Working Group issue
regex
meow is a substring of homeowner
labels
May 27, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<regex>
: Add multiline option and make non-multiline mode the default
#5535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 7 commits into
microsoft:main
from
muellerj2:regex-implement-multiline-option
Jun 14, 2025
Merged
<regex>
: Add multiline option and make non-multiline mode the default
#5535
StephanTLavavej
merged 7 commits into
microsoft:main
from
muellerj2:regex-implement-multiline-option
Jun 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8e4499
to
38709a6
Compare
38709a6
to
1ef8a05
Compare
StephanTLavavej
approved these changes
Jun 9, 2025
Thanks for implementing this formerly-thought-to-be-impossible change! π» I pushed fairly minor changes, including renaming/reworking the escape hatch. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
π» π π± |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
Resolves #73 (also tracked by DevCom-268592 / VSO-629739) and implements LWG-2503. Arguably also resolves DevCom-436138 to the degree that it is reasonable (namely, when the anchor appears in the regex before it starts branching); see the benchmark. Unblocks four libcxx tests.
This PR also aligns the multiline mode with ECMAScript's specification. The anchors now match at any of ECMAScript's line terminators: carriage returns, line feeds, line separators and paragraph separators. Before, the anchors only matched at line feeds.
The PR provides
_REGEX_MAKE_MULTILINE_MODE_DEFAULT
as an escape hatch to return to default multiline mode; if so, non-multiline mode is not available.For POSIX grammars, the new
multiline
option has no effect. While I find this unfortunate, this behavior appears to have been specified in [re.synopt].To simplify the logic in the matcher and avoid some preprocessor #ifdefs, the matcher's internal copy of the regex syntax flags
_Sflags
is mutated before matching starts:multiline
flag is set for all grammars when the escape hatch is defined.multiline
flag is cleared for POSIX grammars when the escape hatch is not defined.These mutations ensure that multiline mode is enabled if and only if the
multiline
flag is set in_Sflags
.I see a potential concern with the implementation in this PR: Even if the escape hatch is set, the matcher still changes behavior and allows anchors to match not just line feeds but all ECMAScript line terminators. It can reasonably be argued that the behavior should be completely unchanged if the escape hatch is defined. Even so, I opted to submit the implementation with ECMAScript-conforming line terminators in this PR first because this simplifies the implementation a lot.
Benchmark
Only for pattern "^bibe" to show that this resolves DevCom-436138.