CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:21:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=394.311234,conversation_content-fragment;desc="conversation_content fragment";dur=784.260358,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=410.570804,nginx;desc="NGINX";dur=1.037461,glb;desc="GLB";dur=104.934409
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=yPtVVPxggwQOk4REFbv%2FezPsduOsrXdd2WC4CWXdg3MUagJDki1ps%2BtC1LcjyTlJJO8Tpl4AuF2KR1vRjTjAdmT6RcqmlUY%2BfPGyGnzhjM%2F9AnTM1EzpEPMPbieBsBmv%2F88iZdAY1sACeI04OlcCl1IaFlIZO%2FLz1m1J9D7wIGSZ2sGVONZg5%2BsYiQQy%2FLVs8aZAVCjHlccveDHHXFCF44hQcpIBqXTF%2BakjFFrNSLPImXZZpWPHZunlaLsLARrxnSrfAjzXrD1H9I97qOAJAA%3D%3D--buPEMdaZHt4QNzxY--gVcU84VvPiAhgeGBwZdioA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1484134422.1753298493; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:21:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:21:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BAD4:36F97A:1045EE1:1345BD7:6881363C
Clean up `vector_algorithms.cpp` again: unsigned bit manipulation, scope guard for multiple return by AlexGuteniev · Pull Request #5532 · microsoft/STL · GitHub
Clean up
Clean up
StephanTLavavej
changed the title
Clean up
Clean up May 22, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Clean up vector_algorithms.cpp
again: unsigned bit manipulation, scope guard for multiple return
#5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 4 commits into
microsoft:main
from
AlexGuteniev:bit-manipulation
May 28, 2025
Merged
Clean up vector_algorithms.cpp
again: unsigned bit manipulation, scope guard for multiple return
#5532
StephanTLavavej
merged 4 commits into
microsoft:main
from
AlexGuteniev:bit-manipulation
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector_aglorithms.cpp
again: unsigned bit manipulation, scope guard for multiple returnvector_algorithms.cpp
again: unsigned bit manipulation, scope guard for multiple return
AlexGuteniev
commented
May 23, 2025
StephanTLavavej
approved these changes
May 28, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🧹 🧹 🧹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Follow up for #5519
_bittestandreset
. The compiler emitsbtc
for the^= 1 << n
pattern, which has the same performance asbtr
for_bittestandreset
.search
could also use_Bingo &= _Bingo - 1
, or_blsr_u32
, but there's not enough evidence in significant enough performance advantage to use thisfind_end
could try_bzhi_u32
, but didn't even bother, here the expectation is even lower.movemask*
. Always 32 bit because internally there is 32-bit destination register, always unsigned because bitmask.int
forcmpestr*
masks, it is compile time, and only few bits, and intrinsic takesint