CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 05:14:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=404.958044,conversation_content-fragment;desc="conversation_content fragment";dur=980.91519,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=441.712719,nginx;desc="NGINX";dur=1.428572,glb;desc="GLB";dur=101.990667
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=VMs3kxwKeGmH7ZIVwRPiJ1pUaGpg%2FF6FIh57YmwgHxKuKh2UOKYku0RjN2LT%2FFJOSp7AqLUQZ%2FkM2VNj3eu62sLZJZ7m2FNnoldmmnjfqc9ZoINRX17zgXP%2BZqKrI92QPbQlpxTq9pcg0CgYLU6Es5JJ%2Ffabv5D9CD5x1FglX0Z99i9E7OijLmnCNkCCMjOWIBSYO2qaOd6IuCuBNL3hWaoe6L4%2BSGz48IsvPsw5RTXrUGI51baVG1Y1Bu0cwPWTrH6qVdBr8z3b01y%2FvWlQUA%3D%3D--O9YV10FRTKM%2Flnaf--2yllMvTYnckSFX1h44JvMA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1222941198.1753334063; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:14:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:14:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DB94:9C104:3A9A3B:4F4441:6881C12F
Improve `search` and `find_end` vectorization by AlexGuteniev Β· Pull Request #5519 Β· microsoft/STL Β· GitHub
Improve
Improve
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve search
and find_end
vectorization
#5519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 8 commits into
microsoft:main
from
AlexGuteniev:the-ultimate-search
May 22, 2025
Merged
Improve search
and find_end
vectorization
#5519
StephanTLavavej
merged 8 commits into
microsoft:main
from
AlexGuteniev:the-ultimate-search
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
May 21, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Population, 9 billion. All SIMD instructions. π€ πΈ π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
Two orthogonal but related changes:
search
path for 8-bit elements (but not forfind_end
). Address concern in Vectorizesearch
for 32-bit and 64-bit elements, also improve 8-bit and 16-bit vectorizationΒ #5484 (comment)Nothing more to tell about the 8-bit AVX2
search
path removal. Some details on SSE4,2 path for 32-bit and 64-bit elements:_Sorting
or bitset algorithms_Sorting
, BSF and BSR are traits members. In_Sorting
, these functions were called infrequently, so they were not worth differentiating for AVX2/SSE4.2. Here we use them in tightest loops, so the performance of better ones may make a difference. Beware that CodeQL comments are harder to verify heretzcnt
/lzcnt
were verified manually._Size_bytes_1
is not passed to extracted functions deliberately. In case of non-inline functions it looks more optimal to compute again than to pass 5th parameter and start using stack on x64. in case of inline functions the compiler will combine the same way computed variables if needed.find_end
cmpestrm
path, and always usecmpeq
infind_end
. The Vectorizesearch
for 32-bit and 64-bit elements, also improve 8-bit and 16-bit vectorizationΒ #5484 (comment) results convinced me not to do this, and keep all existing SSE4.2 paths for 8-bit and 16-bit elements