CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:23:52 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=347.786142,conversation_content-fragment;desc="conversation_content fragment";dur=768.173163,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=388.978877,nginx;desc="NGINX";dur=1.266031,glb;desc="GLB";dur=101.797139
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=UiywP%2BRWEmFNOZkGmupwFVuNZwWxY88tdVwJYnt8Y%2FogvYdpSc5pRWM3pIhuwwm82vaBis55saIfypvV8ZNP48GkQdMaXOo%2Bw12zGkOYbqvQzluWxd5wBHr4bBHkh7m7IHO6sTMbrlxhM4GSHTr2CsGhfJZEX7lYFmYXDyTYs%2FBZDsL%2FO4RbgimT9zYCicW8n0P%2FG2KJa5OPRYcODVyXX482igKma8J2aC7fU0o8blGiMdu178KxpctHs3EXPHYRRpjT3YBMqoS8W4x3duqEBw%3D%3D--zl%2F3LCtiofXtUock--QmM5ChkhkzMrZ0G0wWTwkw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.698237890.1753298631; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:23:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:23:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9D86:36F97A:104A0F3:134B097:688136C7
Build benchmarks for ARM64EC pipeline by cpplearner Β· Pull Request #5517 Β· microsoft/STL Β· GitHub
StephanTLavavej
added
infrastructure
Related to repository automation
test
Related to test code
ARM64
Related to the ARM64 architecture
labels
May 18, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Build benchmarks for ARM64EC pipeline #5517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+6
β0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
May 19, 2025
Thanks for figuring out these incantations! π¦Ύ 6οΈβ£ 4οΈβ£ |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
All shall love ARM64EC and despair! π§ββοΈ π π¦ΉββοΈ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARM64
Related to the ARM64 architecture
infrastructure
Related to repository automation
test
Related to test code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
In #5492, I did not build the benchmarks because I didn't know how to get google-benchmark built for ARM64EC. Now I seem to find the solution.
To create static libraries for ARM64EC, the
/machine:arm64ec
option needs to be passed tolib.exe
. CMake doc mentions that theSTATIC_LIBRARY_OPTIONS
target property holds the options forlib.exe
. This meansbenchmarks/CMakeLists.txt
needs to set this property for each relevant target, including those defined by google-benchmark. But it turns out thatCMAKE_STATIC_LINKER_FLAGS
will also be passed tolib.exe
.Setting
CMAKE_STATIC_LINKER_FLAGS
is simpler, and it affects every target, including those added in the future (either by us or by google-benchmark), which is desirable in this specific case. So this PR chooses to setCMAKE_STATIC_LINKER_FLAGS
.(Note: it seems that
CMAKE_STATIC_LINKER_FLAGS
defaults to/machine:arm64
, so I decided to override it instead of appending/machine:arm64ec
to it, but appending might be more future-proof.)(Note 2: just in case you are interested:
stl/CMakeLists.txt
handles this by adding${VCLIBS_EXPLICIT_MACHINE}
to theSTATIC_LIBRARY_OPTIONS
target property for every relevant target, where${VCLIBS_EXPLICIT_MACHINE}
is/machine:arm64ec
for ARM64EC and empty otherwise.)