CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:59:46 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=293.867688,conversation_content-fragment;desc="conversation_content fragment";dur=532.878649,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=344.335367,nginx;desc="NGINX";dur=0.685056,glb;desc="GLB";dur=101.287985
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=gcIVvPJHmNFJlHEsaX3m0kpjsN8Pxy9xWG17pWLN78Og14rJaFlLB5BcQwLQd8ZXVEZ0SN%2FAoX00BGYJpO4qukRWHdiJA1ucX7njsMmuVFL%2BLKquOybwri4RQBf7ESuQ%2FFTYRWr3511GpGnDQJB%2B4BvBhKaWCiutd46%2FG3EfRSCm4Jgsgxe%2FuEV3FzBB3tu0Gv61%2FMAqhF4HKMwnNn0Baxay7wKXHEkkDV7ufaZ5bjufa88zeMtbStbyrBlFYrBCS2G0r7cmqfWiMeAsG%2FZZsg%3D%3D--knqfIrZiUHr4Wfwa--qCA%2BOIr%2FcrDZTXksoPyyAw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.356966867.1753300786; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:59:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:59:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E788:2A88C5:A49D3:D35A8:68813F32
`<regex>`: Cache bitmasks of negated character classes during matching by muellerj2 · Pull Request #5487 · microsoft/STL · GitHub
StephanTLavavej
added
performance
Must go faster
regex
meow is a substring of homeowner
labels
May 11, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<regex>
: Cache bitmasks of negated character classes during matching
#5487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-cache-negated-char-classes
May 17, 2025
Merged
<regex>
: Cache bitmasks of negated character classes during matching
#5487
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-cache-negated-char-classes
May 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
May 15, 2025
This is great, thank you! 😻 |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
💵 0️⃣ 1️⃣ 🤿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Follow-up to #5403: Since the matcher class just got renamed, we can add some member variables to cache the bitmasks for negated character classes when such negated character classes appear in the regex. This way, we can avoid the class lookup whenever we encounter such character classes during matching.
I also removed the duplicated class-matching logic in
_Skip
: It was annoying to keep_Skip
and_Do_class
in sync, and the logic in_Skip
is by far not as well-tested as_Do_class
.To fuse the duplicated logic, I changed
_Do_class
to no longer modify the matcher's current position. Instead, it now takes a position starting from which the class should match and returns the position just after the sequence actually matched by the class. (Note that this can be more than one character because of collating elements.) If the character class doesn't match,_Do_class
just returns the starting position.The current matcher position is now updated in
_Match_pat
after calling_Do_class
, while_Skip
just checks whether_Do_class
returns the starting position or not.