You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the _MSVC_STL_VERSION macro in yvals_core.h from 143 to 145 to reflect the beginning of work on Visual Studio 18, whose toolset will identify itself as "v145".
Thanks! There's a typo in your PR description - it says it's changing _MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)
We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.
Thanks! There's a typo in your PR description - it says it's changing _MSVC_STL_UPDATE from 202504L to 202504L, which is the same value. However, the actual code change is correct. (You can edit the PR's description to fix it. And in the future, if you need to fix a PR's code changes, you can push additional commits instead of closing the PR and opening a new one.)
We merge PRs simultaneously to our GitHub and MSVC-internal repos, mirrored in a semi-manual process and batched up to save time. Your PR will be part of the next batch, probably next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.
Thanks for the clarification, Stephan! Iβll update the description and keep your suggestions in mind for future PRs.
StephanTLavavej
changed the title
Update _MSVC_STL_VERSION from 143 to 145 for Visual Studio 18 toolset
Update _MSVC_STL_UPDATE to May 2025 and update _MSVC_STL_VERSION to 145
May 9, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the _MSVC_STL_VERSION macro in yvals_core.h from 143 to 145 to reflect the beginning of work on Visual Studio 18, whose toolset will identify itself as "v145".
Updated line:
#define _MSVC_STL_VERSION 143
β#define _MSVC_STL_VERSION 145
#define _MSVC_STL_UPDATE 202504L
β#define _MSVC_STL_UPDATE 202505L
This change ensures consistency with the new toolset versioning and aligns with the guidelines mentioned in issue #5461.
Closes #5461 .