| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:02:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=408.467274,conversation_content-fragment;desc="conversation_content fragment";dur=1023.557723,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=521.507065,nginx;desc="NGINX";dur=1.332389,glb;desc="GLB";dur=102.124474
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BQO07NOGFv1Kf0nJPZGnOsnCMzYAbM18LGEgzx7Q0b6kDk1KJhIoCXGmhZ5P2lOW7QaO4Fmvxm2CpE8mMN4hc8fx8BQzWRscSpH7mp%2BJw2ITTucuWQ9qJO5IOoxrW68lWSloHflFh0wDPkxANGfmTGh%2BH7Qev0dX9l2Uu%2Fyt4gx2bAiGAJLmlmfc7IKKu8Pzo9nB%2BROHeEFrrSKlSYq8EB3uFMn2G0PrbL6188Gk6RZO5CkU21MounukzmGFiNNKMhdKFKUL4%2BcZjSn3k34XOg%3D%3D--aPMPLtg807T%2FcFQ%2F--OTGE0eRj9%2FlrovdTez40Vg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1385742095.1753300922; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:02:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:02:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CF4C:36F97A:1088013:139C693:68813FBA
`<regex>`: Fix quadratic complexity in `regex_search` when regex starts with `?` quantifier or several alternatives by muellerj2 · Pull Request #5457 · microsoft/STL · GitHub
StephanTLavavej
added
performance
Must go faster
regex
meow is a substring of homeowner
labels
May 1, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<regex>: Fix quadratic complexity in regex_search when regex starts with ? quantifier or several alternatives
#5457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 2 commits into
microsoft:main
from
muellerj2:regex-matcher-skip-fix-quadratic-worst-case
May 10, 2025
Merged
<regex>: Fix quadratic complexity in regex_search when regex starts with ? quantifier or several alternatives
#5457
StephanTLavavej
merged 2 commits into
microsoft:main
from
muellerj2:regex-matcher-skip-fix-quadratic-worst-case
May 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with `?` quantifier or several alternatives
AlexGuteniev
reviewed
May 1, 2025
StephanTLavavej
added
performance
StephanTLavavej
approved these changes
May 3, 2025
|
Locally verified too. Given the very clear comment, and the difficulty of verifying this in automated testing without burning a bunch of CPU time, I'm okay with not having test coverage for this. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 9, 2025
|
O(Thanks2) 😹 🚀 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #5452. This is the minimal fix in
_Matcher::_Skipthat I mentioned in the issue: It avoids worst-case running time quadratic in the size of the searched string by giving up on_N_ifnodes with two or more branches.Unfortunately, we can't just give up whenever an
_N_ifis encountered because the parser currently likes to generate such nodes with a single branch. In particular, there is one such node at the beginning of each generated NFA. This means that giving up on such nodes would render_Skippointless for all regular expressions.I confirmed locally that this change is sufficient to fix the quadratic running time that #5452's test case exposes (though the quantifiers still almost double the running time.)