CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:07:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=333.197034,conversation_content-fragment;desc="conversation_content fragment";dur=1106.135208,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=445.677475,nginx;desc="NGINX";dur=0.713454,glb;desc="GLB";dur=100.375385
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=g2UZI7%2Bb8mtvP8VF4APlSiIj5FRnSdmY8%2FMyvrRS2AA1f1sVwqMGpyn8A6mi2NEFrQjxvVug1OSeuNVTQXXEMPO26pkDdqMwxIEfUyGpoIJqTbuTV%2FIKWrKGNYi2Q9TYJP0pfvQzBRey7KuLRkHHz0rtC28epL9wHq%2BLrMf2uc%2BywBTrBf8nlY1kpf9MB%2Bgq0My9LHK7He2VA3%2FLL%2B7hW6OJ0AFDPH3wPiN9%2F%2F8qNXUOT9sJ6jpzLI08k3U7DekasqrC9Zq665vlzzUUwAhMHA%3D%3D--jjzJoHH8hOdKq%2B%2Fs--X3AMS2XB1ObcK4mBeACCcg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1408080678.1753301251; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:07:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:07:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DC7E:3AEC1B:B39D9:E63F5:68814103
`<memory>`: Make algorithms properly destroy objects in constant evaluation by frederick-vs-ja · Pull Request #5449 · microsoft/STL · GitHub
github-project-automation
bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
May 2, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<memory>
: Make algorithms properly destroy objects in constant evaluation
#5449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 5 commits into
microsoft:main
from
frederick-vs-ja:real-constexpr-destroy
May 10, 2025
Merged
<memory>
: Make algorithms properly destroy objects in constant evaluation
#5449
StephanTLavavej
merged 5 commits into
microsoft:main
from
frederick-vs-ja:real-constexpr-destroy
May 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
May 2, 2025
tests/std/tests/P0784R7_library_support_for_more_constexpr_containers/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0784R7_library_support_for_more_constexpr_containers/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
May 3, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 9, 2025
ALL WILL BE DESTROYED!!! 🦹 💣 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Currently, MSVC STL's destroying algorithms skip ranges whose element types are trivially destructible. This is slightly non-conforming, because further access to the destroyed objects should cause core language UB and in turn cause constant evaluation failure.
This PR makes
std::(ranges::)destroy(_at, _n)
always destroy objects during constant evaluation. The behavior difference is currently only observable by Clang due to bugs of MSVC (DevCom-10642767) and EDG (DevCom-10896316).The allocator-aware
_Destroy_range
is not yet touched, because any attempt to access an element destroyed by that overload will raise library UB first.Related to #5225, although the "vectorized implementation" is no-op in these algorithms.The change aboutif consteval
are dropped. See the review comments.