CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:07:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=386.545982,conversation_content-fragment;desc="conversation_content fragment";dur=742.997622,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=486.425421,nginx;desc="NGINX";dur=0.949953,glb;desc="GLB";dur=99.30185
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=AyWUbvXLm2CG6XCGNS%2B9rCd2bwPNsq6MG1f%2B16jl6fFyto%2Bh5P%2FBtncg9zQku5bB%2BDHJvVkRasJF73y3YLSDkQyoVoJ6lekf1ZJWeaGVhInOIqclMcdRHJQQF%2BlgVPGotCjq9gce%2FXFlqscl25bkXyxGX6f5I%2FZMkKH1CtGlev8eov9DM6P%2BQ1ZCSFJDd51Ptx846WSOdZ0BoWGGVEKY%2BU12KgXxVwgVndQm9v%2BEnUQm5SwO%2BHaaKVPtY1rsWbnPAwtsedM2qzQvX0WFdoxEdA%3D%3D--8w%2B%2BZclh%2FfwpcqP9--qIuHsGKlMiHNgZrRWCLzyg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1361371472.1753301242; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:07:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:07:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9EEE:25703E:B4FD4:E7FF3:688140FA
Benchmark: use `not_highly_aligned_allocator` in more places by AlexGuteniev Β· Pull Request #5443 Β· microsoft/STL Β· GitHub
Benchmark: use
AlexGuteniev
changed the title
Benchmark: use not_higghly_aligned allocator in more places
Benchmark: use Apr 26, 2025
AlexGuteniev
changed the title
Benchmark: use
Benchmark: use Apr 26, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Benchmark: use not_highly_aligned_allocator
in more places
#5443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not_highly_aligned
allocator in more places
not_highly_aligned
allocator in more placesnot_highly_aligned_allocator
in more places
StephanTLavavej
approved these changes
Apr 28, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 9, 2025
Thanks for improving the consistency of our benchmarks! π π π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
Resolves #5035
To avoid trying both aligned and unaligned allocators, try just unaligned. This makes sure we're checking the worst case, where vectorization would be of less benefit.
Only change the container for potentially-vectorized algorithm benchmark. For, like, random it does not make sense. Also
vector<bool>
is vectorized, if we consider GPR-based vectorization as still vectorization, but this will not be sensitive to the alignment.Some vector algorithms that are potentially sensitive to the alignment are in fact sensitive to alignment, some are not or almost not. The ones that are sensitive are simplest searches, or data movement. Consider
adjacent_find
as a good example of the sensitive one, here's how the results became worse:adjacent_find
does two AVX loads of the same input data at a time, with aligned allocator just one of the loads is unaligned, with unaligned allocator both of them are unaligned. So it stresses the processor ability to deal with unaligned data.Skipped also
bitset
benchmarks. They are harder to unalign, since they use some stack containers with deduced types. I'm confident thatbitset
from/to string conversion are examples of algorithm that are not very sensitive to the alignment.Some of recently added benchmark are not changed in this PR, because they already use not highly aligned allocator.
Also I expected
replace_copy
as one of the sensitive, but auto-vectorization is broken at all in latest Preview π.Created DevCom-10895463
Drive-by: proper optimization barriers in replace family benchmarks.