| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:22:45 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=353.354561,conversation_content-fragment;desc="conversation_content fragment";dur=694.699127,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=431.70201,nginx;desc="NGINX";dur=1.263253,glb;desc="GLB";dur=102.204275
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=v%2BGshO02i47AeUnDMpUHCLJrU2QW%2BWsQBhr1ZcznsqZrzsNVS62BfGWIy4YxFQ3I6cf157Szo1C1GiRQiXGh77RrVbbFGjxo7chc1wX0lOsZ5OEX1K8jg8xdi%2BsB777%2FwKl0%2BnGYu2f8kIed0fuyjJOL%2BStdNexgKuDnd%2BregwRAa3AJejTYRrjM1wJjJcHd6NcETt7hnzSpkv8mzUXEv0o7bw%2BAMhvQcg4Ilj%2FAeZuKhik6izfYTsjwmNLkM6xI3g9omPZwpyRMX6570liNGw%3D%3D--UcVAbBUchjJnT6Kh--E73XCjiW8vMxSWSvbwD3cg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.627849907.1753298564; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:22:44 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:22:44 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8CC0:2DEF93:105106D:13518CD:68813684
Win8 baseline: Simplify `<filesystem>` API calls by StephanTLavavej · Pull Request #5434 · microsoft/STL · GitHub
Win8 baseline: Simplify
Win8 baseline: Simplify
StephanTLavavej
added
enhancement
Something can be improved
filesystem
C++17 filesystem
labels
Apr 25, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Win8 baseline: Simplify <filesystem> API calls
#5434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 3 commits into
microsoft:main
from
StephanTLavavej:doom-3-filesystem
Apr 29, 2025
Merged
Win8 baseline: Simplify <filesystem> API calls
#5434
StephanTLavavej
merged 3 commits into
microsoft:main
from
StephanTLavavej:doom-3-filesystem
Apr 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ [`CopyFile2`](https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-copyfile2) is "Windows 8 \[desktop apps | UWP apps\]". + [`CopyFileW`](https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-copyfilew) is "Windows XP \[desktop apps | UWP apps\]". + We were inconsistently guarding this with `defined(_ONECORE)` versus `defined(_CRT_APP)`.
+ [`CreateFile2`](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfile2) is "Windows 8 \[desktop apps | UWP apps\]". + [`CreateFileW`](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilew) is "Windows XP \[desktop apps only\]".
…ad of `GetFileInformationByHandle`. + [`GetFileInformationByHandleEx`](https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getfileinformationbyhandleex) is "Windows Vista \[desktop apps | UWP apps\]". + [`GetFileInformationByHandle`](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfileinformationbyhandle) is "Windows XP \[desktop apps only\]". + The documentation around `FileIdInfo`/[`FILE_ID_INFO`](https://learn.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_id_info) is confusing. It claims "Minimum supported client: None supported" and "Minimum supported server: Windows Server 2012 \[desktop apps only\]", but in modern `filesystem.cpp` it is our only codepath when `defined(_CRT_APP)`. That suggests that it works on Client and works for UWP apps, so I think it might actually be "Windows 8 \[desktop apps | UWP apps\]".
StephanTLavavej
added
enhancement
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
zacklj89
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the 🟥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
🗺️ Overview
<filesystem>implementation (and older<experimental/filesystem>) contains several codepaths of the form "if we're a UWP app, call a modern API, otherwise call a legacy API". This is not only twice as much code to maintain, but we don't have automated test coverage for UWP apps, which greatly increases risk. Now that our baseline OS is Win8, we can send everything through the modern APIs.filesystem.cpp, where_Get_file_id_by_handle()has the unusual pattern of calling modernGetFileInformationByHandleEx()and then falling back to legacyGetFileInformationByHandle(). See the commit notes below for why I suspect this is unnecessary. This code was moved around by [copy_file] allowFILE_SHARE_*#2718 but the original logic dates back to the initial GitHub commit.⚙️ Commits
CopyFile2instead ofCopyFileW.CopyFile2is "Windows 8 [desktop apps | UWP apps]".CopyFileWis "Windows XP [desktop apps | UWP apps]".defined(_ONECORE)versusdefined(_CRT_APP).CreateFile2instead ofCreateFileW.CreateFile2is "Windows 8 [desktop apps | UWP apps]".CreateFileWis "Windows XP [desktop apps only]".GetFileInformationByHandleExinstead ofGetFileInformationByHandle.GetFileInformationByHandleExis "Windows Vista [desktop apps | UWP apps]".GetFileInformationByHandleis "Windows XP [desktop apps only]".FileIdInfo/FILE_ID_INFOis confusing. It claims "Minimum supported client: None supported" and "Minimum supported server: Windows Server 2012 [desktop apps only]", but in modernfilesystem.cppit is our only codepath whendefined(_CRT_APP). That suggests that it works on Client and works for UWP apps, so I think it might actually be "Windows 8 [desktop apps | UWP apps]". This PR certainly appears to work on my client Windows 11 machine.📜 Changelog
<filesystem>implementation by unconditionally calling APIs that were added in Windows 8.