CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:59:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=307.006449,conversation_content-fragment;desc="conversation_content fragment";dur=647.794574,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=421.335287,nginx;desc="NGINX";dur=0.834144,glb;desc="GLB";dur=101.392029
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=aTAhDd0KA%2Bh86qdt0MX3JGN4fpZ79IfQaQR%2FOXpqDyqkU6ju4Oltd%2Fq1pBerb3dBJGEhby00TYczIu0Z4rw0TCjrn3%2BkT2wBjeUAbuxx%2BtGsg1gCinuINUXCDcBqdmZvhSG9Nn8PCOEyvfI%2B2KqjG%2FdRoEQeDX1RVxOdV%2BIgrSJCfBZofJdnSF%2FlauN9hTmR5%2FKmqAyKZItRzBltKGCJs1NSf3Fyk1BH5lZITnika588rJbhZ9FTpf0S79lJm15fXNZGoHvMCxhSsv4O0hgIEg%3D%3D--J2s8C0I6SphQg3qo--bqTtVnh5pthWUOkqtuwMmg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1626739851.1753300773; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:59:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:59:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9394:3AEC1B:A7D78:D669D:68813F25
`<locale>`: Improve `std::collate::do_transform()`'s handling of wrongly encoded input by muellerj2 ยท Pull Request #5431 ยท microsoft/STL ยท GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<locale>
: Improve std::collate::do_transform()
's handling of wrongly encoded input
#5431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 3 commits into
microsoft:main
from
muellerj2:locale-collate-handling-invalid-input
Apr 29, 2025
Merged
<locale>
: Improve std::collate::do_transform()
's handling of wrongly encoded input
#5431
StephanTLavavej
merged 3 commits into
microsoft:main
from
muellerj2:locale-collate-handling-invalid-input
Apr 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
โฆgly encoded input
StephanTLavavej
approved these changes
Apr 24, 2025
Thanks! ๐ป An empty string for error seems fine. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for noticing and fixing these long-standing mistakes! ๐ฆ ๐๏ธ ๐ป |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canโt perform that action at this time.
Resolves #5210.
Changes:
SIZE_MAX
on error, notINT_MAX
like their UCRT counterparts._Wcsxfrm()
, the return value is now correctly set tostatic_cast<size_t>(-1)
for one error case, bringing it in line with the other error case. Previously, it was set toINT_MAX
, which is potentially a valid length for a sort key.collate::do_transform()
to return an empty string in the error case instead of throwing a confusinglength_error("string too large")
.collate::do_transform()
should do in case of error.length_error
. Mayberuntime_error
?regex_match
andregex_search
really shouldn't throw just because the searched input string isn't valid UTF-8.