CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix heap-use-after-free for _HAS_EXCEPTIONS=0
#5406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@microsoft-github-policy-service agree |
Can we delete ( |
We do have some precedent of outright In this case, because the option is ancient and the affected constructors (e.g. |
tests/std/tests/GH_005276_system_error_heap-use-after-free/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005276_system_error_heap-use-after-free/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005276_system_error_heap-use-after-free/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005276_system_error_heap-use-after-free/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005276_system_error_heap-use-after-free/test.cpp
Outdated
Show resolved
Hide resolved
Thanks for fixing this surprisingly long-standing correctness bug! π» I pushed some test changes, and double-checked that the product code changes are complete. Note for the future: we recommend against force-pushing after code review has begun, because GitHub makes it harder to see what's changed. We merge PRs simultaneously to GitHub and our MSVC-internal repo in a semi-manual process, batched up to save time. Your PR will be part of the next batch, possibly this week but more likely next week depending on how busy I am. I'll post comments here as I prepare your PR for merging! |
@StephanTLavavej Thanks for giving it the finishing touch! |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing this bug and congratulations on your first microsoft/STL commit! π π» π |
Fixes #5276.