CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 05:19:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=372.058297,conversation_content-fragment;desc="conversation_content fragment";dur=526.353801,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=363.379069,nginx;desc="NGINX";dur=1.123701,glb;desc="GLB";dur=101.989786
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=21C2zMa251n8IfoSTBV7olOZaMpWRlqKrb93CWXkem7yIzzB5RlbiknFutYAM0A4RIf7Kw5Q3vSKIl%2Fl8JbITH9xf4TLpe8dh7Xu37im%2BlTczijtX5E0nVLoQjzZLgwzAyBRfnaw739lWjAATo%2BIzou55HFxDqiModWCf76qiXOYaGrFVUbcL640eAIlHqNTESuXtdLzH8wwiwQwnx8fLEx92WBaaXCZUjUu0JcC5mKvYwO7s0Y6F5yuneY4QJ8Nr1TWPS6FyDKjOrZO8d1hpg%3D%3D--qBAayrGZqinyKw9u--2mab4SarhfrF7qERdHeuiQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1177431674.1753334351; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:19:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:19:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C5DE:0A93:300906:415DCA:6881C24F
Update the SPDX-License-Identifier for Ryu-derived sources by StephanTLavavej · Pull Request #5401 · microsoft/STL · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update the SPDX-License-Identifier for Ryu-derived sources #5401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not legal advice, but this LGTM 👮
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #5397.
I am neither a lawyer nor a cat, and this is not a licensing change. It is simply clarifying our machine-searchable SPDX-License-Identifier to align with our original intentions.
Most of our source files are available under the Apache License v2.0 with LLVM Exception, chosen to match libc++. Our
<charconv>
implementation was derived from the ulfjack/ryu repo'sryu/
subdirectory, which is dual-licensed. Quoting that repo's README:We chose to use Ryu under the Boost Software License and accordingly copied that banner into our sources. (We're pretty careful about isolating derived code into separate source files, especially in product code.)
The important thing for us about the Boost Software License is how it explicitly doesn't require attribution when shipping compiled software to end users, which is something that the LLVM Exception also addresses. (End users don't even know what a C++ Standard Library is.)
As a result, our files implementing and testing
<charconv>
(although not<charconv>
itself, as it's the layer above Ryu) contain both our usualSPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
and the (verbose) Boost Software License, both of which must be complied with (which we believe is pretty easy, due to their aligned natures regarding attribution). At the time, I didn't understand that the SPDX syntax wants to express this with AND; see SPDX IDs: How to use.Again, note the difference: Upstream Ryu is effectively Apache-2.0 OR BSL-1.0 (as it says "Alternatively"). We've chosen the BSL-1.0 option, then added our usual license, so our derived sources are Apache-2.0 WITH LLVM-exception AND BSL-1.0. The OR operator would not be suitable for these derived sources, otherwise further derived code could drop the BSL-1.0.