CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 05:08:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=286.899101,conversation_content-fragment;desc="conversation_content fragment";dur=532.167471,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=415.926104,nginx;desc="NGINX";dur=1.016149,glb;desc="GLB";dur=100.636227
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jz4PlZOylTw0OvY%2BhlrjAwOiICtHscMZtukTHu7bKBgd%2BvatiLXzyMgXWwQe6F3n1w5veqtB6kvVkea4I2DqAN7wjojhgE9UXdN8m%2Bz90TXYOnGj3CxF77QnKbNnR8hH7IQoe7vvCfsnNrkfzYBqkq81GzJfheAflCpEaJ4%2BmAYo%2FinWYSReKxup6Y1O2hysC4Te%2FQz3NnBIUmvR7RysoJVFnwYm6zCd4gysAj5dXHCdGms%2BMKSMVjaFz5aW%2Bm3QN1OhOWB8m5CrmWZ8YgaYMA%3D%3D--qOl8rTTxEoHsKB0D--QVLHSG5kI9JngJ%2BZUacFrw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.934391464.1753333726; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:08:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:08:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 81B0:124FF4:13632B7:178E450:6881BFDE
`<regex>`: Permit escaping of closing brackets in POSIX regexes by muellerj2 ยท Pull Request #5399 ยท microsoft/STL ยท GitHub
StephanTLavavej
added
enhancement
Something can be improved
regex
meow is a substring of homeowner
labels
Apr 10, 2025
muellerj2
deleted the
regex-permit-escaping-of-right-brackets-in-posix-regexes
branch
May 31, 2025 21:31
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<regex>
: Permit escaping of closing brackets in POSIX regexes
#5399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-permit-escaping-of-right-brackets-in-posix-regexes
Apr 22, 2025
Merged
<regex>
: Permit escaping of closing brackets in POSIX regexes
#5399
StephanTLavavej
merged 1 commit into
microsoft:main
from
muellerj2:regex-permit-escaping-of-right-brackets-in-posix-regexes
Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Apr 11, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for bringing us into the future of POSIX! ๐ธ ๐ ๐ช |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canโt perform that action at this time.
Short follow-up to #5380 to support escapes for closing brackets in POSIX regexes in accordance with the most recent POSIX standard version: https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap09.html#tag_09_03_02 for basic and https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap09.html#tag_09_04_02 for extended regexes.
Because of the (expected) test failures caused by this change, I noticed that the tests in
gh_5244_atomescape_posix_common
are called twice forextended
andegrep
fromtest_gh_5244_atomescape_extended_or_egrep
: Once viagh_5244_atomescape_posix_not_awk
and once viagh_5244_atomescape_extended_egrep_awk
. That's once more than necessary, so let's get rid of this double-testing. I opted to remove the call ofgh_5244_atomescape_posix_common
ingh_5244_atomescape_extended_egrep_awk
, but this means a call has to be added togh_5244_atomescape_awk
so that these common POSIX tests are still exercised in awk mode.