CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:16:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=548.887096,conversation_content-fragment;desc="conversation_content fragment";dur=808.364016,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=591.481091,nginx;desc="NGINX";dur=1.558484,glb;desc="GLB";dur=101.996386
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=NjVek0FSsn%2BNdiWBjkuyro%2FVPi1nt2w%2BDbIu6YtXDtguW52DKz52x42GT56sqORpO70zFe%2BfMFkmsN%2BCNp63mI2U6QeGUpJuwSMpsmWHtayLTd%2FwFSP64QJeYhmfyj4ePWajfj3ZKmu98EBkkjAM6hXUVd%2Fi605XL8mBUCfNK9MKvvxyMVmy9TvyUtCZdLuhuFAd%2FucZ%2FnV77ssOqL9Q84Sgqioy6nYsFrb5NXxcVhPrxf1sWOtvuRUB3vmwMLGiTpM8558VW08sh9tGK7Appg%3D%3D--la4YlGbGCTatnJNa--d0JibVWTrJjQrvGG8Ch0%2FA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1346612087.1753301783; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:16:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:16:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BC0E:256CA9:1082F5C:139E6C8:68814317
Fix sporadic test failures by avoiding excessive compiler memory consumption by StephanTLavavej · Pull Request #5383 · microsoft/STL · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix sporadic test failures by avoiding excessive compiler memory consumption #5383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 1 commit into
microsoft:main
from
StephanTLavavej:x86-is-an-abomination
Apr 10, 2025
Merged
Fix sporadic test failures by avoiding excessive compiler memory consumption #5383
StephanTLavavej
merged 1 commit into
microsoft:main
from
StephanTLavavej:x86-is-an-abomination
Apr 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses all of the tests that were consuming 3+ GB for x86 /analyze:only: Test | Before | After | -------------------------------------|--------------:|--------------:| `P0896R4_ranges_alg_copy` | 3,036,147,712 | 657,166,336 | `P0896R4_ranges_alg_transform_unary` | 3,199,823,872 | 695,132,160 | `P2321R2_views_adjacent` | 3,887,595,520 | 1,020,297,216 | `P2321R2_views_adjacent_transform` | 3,404,570,624 | 940,150,784 | `P2441R2_views_join_with` | 3,391,266,816 | 892,010,496 |
davidmrdavid
approved these changes
Mar 31, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes internal VSO-2431296, where
P2321R2_views_adjacent
is sporadically running out of memory for x86-native/analyze:only
configurations. (Internal builds of the compiler have a bit more debug logic than retail builds, which is why we haven't seen these failures in our GitHub PR/CI system.)Related:
Our stressful ranges/views tests, combined with Static Analysis's increased compiler memory consumption, interact poorly with the ABSOLUTE ABOMINATION of x86-hosted toolsets in the year 2025.
I modified #3567's incantations to find all of the tests that were consuming 3+ GB for x86-native
/analyze:only
, then added our usual workarounds, reducing the peak working set sizes (in bytes) to reasonable levels:P0896R4_ranges_alg_copy
P0896R4_ranges_alg_transform_unary
P2321R2_views_adjacent
P2321R2_views_adjacent_transform
P2441R2_views_join_with
As usual, the workarounds are architecture-independent, since consuming tons of memory isn't great even for properly x64-hosted compilers.
I also checked the plain configurations (original recipe C1XX, not extra crispy
/analyze:only
). There are only a few at 2+ GB for x86-native, and none over 3 GB, so while they're still concerning, they aren't risking OOM:P2374R4_views_cartesian_product_recommended_practices
P0896R4_ranges_alg_mismatch
P2321R2_views_adjacent
P2374R4_views_cartesian_product
(Note that
/analyze:only
is just a variant of/analyze
that skips codegen.)