| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:01:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=287.109787,conversation_content-fragment;desc="conversation_content fragment";dur=728.524239,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=390.993342,nginx;desc="NGINX";dur=1.114341,glb;desc="GLB";dur=101.008226
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pVG8Yy%2FiOfJp8AYl%2B%2B8hFWxf3R%2FOZPaOFRvggV918%2FUtk3kd2Y7vIfdqCv86KZN8BOipFz9pz61IVg89UQ52m20C7Gz8Xq%2FZxsX7yEFs6YAx0oQdHznTmu5UzW3gHdBMhZdbQR83tj4GrrJHSG8G3gQaO%2BI3fEzONd1SWqfhw79FKUpR75DBTr9UYR5kboXZXROgkYcm%2BboOUSHAXf2wuD76rW7JmMYFL5GxT4ttXpwNP73KPx3sCl2A7IHwpMISRCuByPI%2Fv0z9KlUD1IGUOQ%3D%3D--RSMMnOUHRQlOqRyW--tzq2XVwulwz0pPrFWRa1YA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.91813469.1753300871; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:01:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:01:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D478:124FF4:106AD63:137EA98:68813F87
`<xhash>`: Get rid of tricks for transparent overloads of hash containers by frederick-vs-ja · Pull Request #5208 · microsoft/STL · GitHub
frederick-vs-ja
force-pushed
the
transparent-hash-containers-no-trick
branch
from
December 27, 2024 12:28
StephanTLavavej
added
bug
Something isn't working
and removed
enhancement
Something can be improved
labels
Jan 8, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<xhash>: Get rid of tricks for transparent overloads of hash containers
#5208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 3 commits into
microsoft:main
from
frederick-vs-ja:transparent-hash-containers-no-trick
Jan 14, 2025
Merged
<xhash>: Get rid of tricks for transparent overloads of hash containers
#5208
StephanTLavavej
merged 3 commits into
microsoft:main
from
frederick-vs-ja:transparent-hash-containers-no-trick
Jan 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
transparent-hash-containers-no-trick
branch
from
ffce9d1 to
318ba54
Compare
StephanTLavavej
added
bug
StephanTLavavej
approved these changes
Jan 10, 2025
|
Thanks, this makes a lot more sense than the old wacky scheme! 😻 I pushed a trivial change to fuse regions. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for properly constraining these member functions! 🎉 🥳 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR removes overload-merging tricks (which supports implementing WG21-P1690R1) for hash containers by re-implementing the shapes of the involved functions as specified in standard. Currently, the trick is buggy when the transparent overloads are enabled and the arguments are brace initializer lists (see DevCom-10819520).
Another approach can be changing the default template argument from
voidtokey_type. However, this would make more bogus uses accepted, although it might be still conforming. I guess the safest way is "Do What The Standard Says" here.Fixes #5207.