CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:09:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=291.139503,conversation_content-fragment;desc="conversation_content fragment";dur=783.805541,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=413.363743,nginx;desc="NGINX";dur=0.619471,glb;desc="GLB";dur=99.691558
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jKicAuHCZ05bdVH3S%2BptQdH9LCA9Qhb%2F%2BrLE%2FekLCXRJkOJF2uHV8PUNFS9osnQbCfMTIEb%2B6ZCxLNvz7pg1UE2J7GSm%2FcAwoGq5FI6OwSvKdOis5SlJRkPp7f2WqElierXOvfQlzc8QnVN0arPz6YLCrwWIUPAAsA7Pa2LDRmyfBONV6gCCtj5rlh7OHfufpFHr5UMFQDnFF5AF3AlHSK%2FxRM5F5dLnsVHptnl66gRcB0MlkzG4RSYHe9u%2B0nHX6UaYY5lmPB4%2FsReGTHUXYg%3D%3D--E%2BGmJpTk%2BGLKzkYs--51cFGbVfiEQ6CEZZ73Zojw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1176894360.1753301342; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:09:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:09:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9042:12F48D:10997C0:13B1639:6881415E
`<format>`: Detect some invalid contiguous ranges in `range_formatter` by frederick-vs-ja ยท Pull Request #5187 ยท microsoft/STL ยท GitHub
StephanTLavavej
added
enhancement
Something can be improved
ranges
C++20/23 ranges
format
C++20/23 format
labels
Dec 12, 2024
CaseyCarter
added
bug
Something isn't working
and removed
enhancement
Something can be improved
labels
Dec 13, 2024
CaseyCarter
assigned
CaseyCarter and
frederick-vs-ja and unassigned
StephanTLavavej and
CaseyCarter
Dec 13, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<format>
: Detect some invalid contiguous ranges in range_formatter
#5187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 5 commits into
microsoft:main
from
frederick-vs-ja:contiguously-small
Jan 14, 2025
Merged
<format>
: Detect some invalid contiguous ranges in range_formatter
#5187
StephanTLavavej
merged 5 commits into
microsoft:main
from
frederick-vs-ja:contiguously-small
Jan 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Dec 12, 2024
tests/std/tests/P2286R8_text_formatting_range_string_death/test.cpp
Outdated
Show resolved
Hide resolved
I haven't thought about this too deeply, but I'd recommend any pathological checks be controlled by |
CaseyCarter
approved these changes
Dec 17, 2024
StephanTLavavej
approved these changes
Jan 7, 2025
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing this obscure bug! ๐ ๏ธ ๐ ๐ช |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canโt perform that action at this time.
The following code snippet detects some "impossible" huge range.
STL/stl/inc/format
Lines 3283 to 3290 in 89ca073
The semantic requirements of
contiguous_iterator
depend on pointer arithmetic, so when the underlyingcontiguous_range
has more than 1 elements, the range must denote a contiguous element sequence of some array to be valid (otherwise, reaching from the beginning to the end causes UB). Moreover, the C++ object model doesn't permit an array object to have more thanSIZE_MAX
element. So we can infer that when the size of the contiguous range is too large to fit intosize_t
, the range must be invalid, and thus formatting it results in UB (per [iterator.requirements.general]/10, although the paragraph seemingly accidently makes infinite range invalid).Fixes #5182.