CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:00:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=460.712889,conversation_content-fragment;desc="conversation_content fragment";dur=1101.340499,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=564.984535,nginx;desc="NGINX";dur=1.594448,glb;desc="GLB";dur=101.443558
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=yp531q0rRLeRBrVpDEKvfq3KZCjSKlaQL6pIrxrH7FO6S2AhxgIlSvkTqiowonN46at%2BDNHJ%2BRrPdB0Hcnt4vejqITbD0Xv1XQ8d0PEHil%2F4DahGqvySRqDl76x3IQUnj%2B8raWYTI%2Blo7dcxf5%2FpLb8GjaKtP%2BaouxS%2FZzasPY%2Bzj584P2IY5QsHmLRzviEHb7eDdBYtF4r7PtQ1xUp7gKsXVnY29c9Sn9gqLminALZR2zY3ZLubNHm0bzS6zrwuVbetiHBQU251n6fGCG8fHw%3D%3D--yJiMGMLqfmn%2B%2B%2F%2Fs--twLEIYejLMLe2nxjt2FsFQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.13292654.1753300831; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:00:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:00:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BD90:256CA9:106C06E:137F67A:68813F5F
Fix false positives by `filesystem::equivalent` on file systems with transient file IDs by muellerj2 Β· Pull Request #5130 Β· microsoft/STL Β· GitHub
Fix false positives by
Fix false positives by
CaseyCarter
added
bug
Something isn't working
affects redist
Results in changes to separately compiled bits
filesystem
C++17 filesystem
labels
Nov 24, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix false positives by filesystem::equivalent
on file systems with transient file IDs
#5130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 5 commits into
microsoft:main
from
muellerj2:fix-filesystem-equivalent
Dec 5, 2024
Merged
Fix false positives by filesystem::equivalent
on file systems with transient file IDs
#5130
StephanTLavavej
merged 5 commits into
microsoft:main
from
muellerj2:fix-filesystem-equivalent
Dec 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦transient file IDs
muellerj2
commented
Nov 24, 2024
StephanTLavavej
approved these changes
Dec 2, 2024
Thanks, this is awesome! π» I pushed cosmetic changes. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks again for figuring out how to fix this runtime correctness bug! π π° π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects redist
Results in changes to separately compiled bits
bug
Something isn't working
filesystem
C++17 filesystem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
Fixes #3571 for
<filesystem>
and<experimental/filesystem>
.The fix for
<experimental/filesystem>
affects the redist because it changes the implementation of_Equivalent
infilesys.cpp
that is exported by msvcp140.dll.There is no additional test coverage because a reliable test for this issue would involve setting up a drive commonly producing such transient file IDs. But I verified manually with a drive shared by Remote Desktop that (a) false positives by
std::filesystem::equivalent
andstd::experimental::filesystem::equivalent
are present without this PR and (b) are gone with it. I also added comments at the top of_Equivalent
and__std_fs_equivalent
that reference #3571 and serve as a reminder why the file handles can't be closed before file IDs for both files have been obtained.