| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:02:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=480.136442,conversation_content-fragment;desc="conversation_content fragment";dur=730.998621,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=532.702224,nginx;desc="NGINX";dur=1.371058,glb;desc="GLB";dur=100.066023
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1sCj7AZIbuC4R4FBBBiZlAGFe5uTpZf689evr8aSsm0TcqRyj0fXWm2RDrsIXnYwpewIfD6%2FMrhXYg959TLYRwGtcSJLSQMBo1euAkjELcg6picusfIdYscciX8tReAnCn79YkA0lDYPCWLRLUk8p0DJQ8Ubqi1lgG%2BspAlYmDCceg4WcPmMO2NXhM6422Rdanb4qPBt39JuGnXmJQpm17F8bdY84VIp%2FitNlqQYtQW%2BWCJ5QCM3V%2B83EOJFdrwwePz0PouMVQE90d1QuTMVnQ%3D%3D--eJ1%2FNHOx22obzAsP--9%2FgNDSbBaNTbnq%2F7H40seQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.633373368.1753300934; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:02:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:02:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E7C4:941DF:107625F:138A93C:68813FC6
Internally remove workaround in `Dev09_056375_locale_cleanup` by CaseyCarter · Pull Request #5103 · microsoft/STL · GitHub
Internally remove workaround in
Internally remove workaround in
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Internally remove workaround in Dev09_056375_locale_cleanup
#5103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 1 commit into
microsoft:main
from
CaseyCarter:if-you-love-some-library
Nov 22, 2024
Merged
Internally remove workaround in Dev09_056375_locale_cleanup
#5103
StephanTLavavej
merged 1 commit into
microsoft:main
from
CaseyCarter:if-you-love-some-library
Nov 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FreeLibrary` call made the ASan runtime do Very Bad Things when statically linking the STL. The ASan bug was fixed by MSVC-PR-582781. Let's enable test coverage internally to prevent regressions until the fix ships in 17.13p2. Fixes VSO-2046190/AB#2046190.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Nov 20, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
🌏 🧹 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The
FreeLibrarycall made the ASan runtime do Very Bad Things when statically linking the STL. The ASan bug was fixed by AddressSanitizer-PR-582781 (merged intoprod/beby MSVC-PR-585734 on 2024-10-16). Let's enable test coverage internally to prevent regressions until the fix ships in 17.13p2.Fixes VSO-2046190/AB#2046190.
(I've done some extra validation with the trunk compiler as well to make sure this won't become a problem when merging.)