You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply overly generalized traits and algorithms, which are actually specific to std::char_traits and sub_match.
Add const to some operator(). A (non-static, non-explicit-parameter) operator() without const usually implies the status of the function can be modified, which is not the case for the touched functors.
Use = default; and default member initializers for some classes.
Strengthend exception specifications for some funcitons.
Maybe in a future PR: Moving some function bodies into class bodies. Separation doesn't seem necessary to me, but the change is a bit large.
I had to push an additional commit to fix regressions found by our Perennial test suite. See the cited Standardese for const-default-constructible and https://godbolt.org/z/GeWYxf37f .
enhancementSomething can be improvedregexmeow is a substring of homeowner
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::char_traits
andsub_match
.const
to someoperator()
. A (non-static, non-explicit-parameter)operator()
withoutconst
usually implies the status of the function can be modified, which is not the case for the touched functors.= default;
and default member initializers for some classes.Maybe in a future PR: Moving some function bodies into class bodies. Separation doesn't seem necessary to me, but the change is a bit large.