Add LIT parameter `priority` #5032

CaseyCarter · 2024-10-23T02:18:04Z

To control test process priority. Defaults to IDLE_PRIORITY_CLASS. Has no effect without pip install psutil.

To control test process priority. Defaults to `IDLE_PRIORITY_CLASS`.

tests/utils/stl/test/params.py

StephanTLavavej · 2024-10-23T14:19:51Z

Thanks, this is awesome! 😻 Now test runs should interfere less with Microsoft Teams. 🐈‍⬛

I pushed a commit to print a note when psutil isn't installed. This looks like:

D:\GitHub\STL\out\x64>pip list
Package Version
------- -------
pip     24.2
D:\GitHub\STL\out\x64>python tests\utils\stl-lit\stl-lit.py %STL%\tests\std\tests\Dev11_0272959_make_signed --succinct
NOTE: Module "psutil" is not installed, so the priority setting "idle" has no effect.
-- Testing: 49 tests, 32 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 1.78s
Total Discovered Tests: 49
  Unsupported:  4 (8.16%)
  Passed     : 45 (91.84%)
D:\GitHub\STL\out\x64>python tests\utils\stl-lit\stl-lit.py %STL%\tests\std\tests\Dev11_0272959_make_signed --succinct -Dpriority=low
NOTE: Module "psutil" is not installed, so the priority setting "low" has no effect.
-- Testing: 49 tests, 32 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 1.78s
Total Discovered Tests: 49
  Unsupported:  4 (8.16%)
  Passed     : 45 (91.84%)
D:\GitHub\STL\out\x64>pip install psutil
Collecting psutil
  Downloading psutil-6.1.0-cp37-abi3-win_amd64.whl.metadata (23 kB)
Downloading psutil-6.1.0-cp37-abi3-win_amd64.whl (254 kB)
Installing collected packages: psutil
Successfully installed psutil-6.1.0
D:\GitHub\STL\out\x64>pip list
Package Version
------- -------
pip     24.2
psutil  6.1.0
D:\GitHub\STL\out\x64>python tests\utils\stl-lit\stl-lit.py %STL%\tests\std\tests\Dev11_0272959_make_signed --succinct
-- Testing: 49 tests, 32 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 1.81s
Total Discovered Tests: 49
  Unsupported:  4 (8.16%)
  Passed     : 45 (91.84%)
D:\GitHub\STL\out\x64>python tests\utils\stl-lit\stl-lit.py %STL%\tests\std\tests\Dev11_0272959_make_signed --succinct -Dpriority=low
-- Testing: 49 tests, 32 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 1.78s
Total Discovered Tests: 49
  Unsupported:  4 (8.16%)
  Passed     : 45 (91.84%)

StephanTLavavej · 2024-10-23T14:41:27Z

Relabeled as this affects local test runs, not repository automation. We actually no longer install psutil in the VM image, because our new security policies hate pip install and I don't know how to cromulently phrase it when preparing a non-corpnet image.

CaseyCarter · 2024-10-23T15:30:11Z

Thanks, this is awesome! 😻 Now test runs should interfere less with Microsoft Teams. 🐈‍⬛

Yeah, I had no doubt my motivation would be obvious to anyone who saw my slideshow in standup yesterday =)

I pushed a commit to print a note when psutil isn't installed.

I went back and forth on this a couple of times trying to avoid any visible message when the user didn't explicitly specify a value for the parameter. This turns out to be surprisingly complicated to do without adding a separate default to the set of acceptable values that LIT reports when you specify a value not in that set. Now it occurs to me that "default" (currently equivalent to "idle") wouldn't be terrible. I'll keep it in mind and we'll make a change if this message is too scary for new users.

StephanTLavavej · 2024-10-23T16:31:02Z

I think we do actually want a message when the default is used, since otherwise the unfriendly behavior is invisible. (What's missing is a way to suppress the message without installing psutil)

StephanTLavavej · 2024-10-23T19:09:53Z

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej · 2024-10-24T15:48:08Z

🐈‍⬛ 📹 📺

Add LIT parameter priority

ad59273

To control test process priority. Defaults to `IDLE_PRIORITY_CLASS`.

CaseyCarter added the infrastructure Related to repository automation label Oct 23, 2024

CaseyCarter requested a review from a team as a code owner October 23, 2024 02:18

CaseyCarter commented Oct 23, 2024

View reviewed changes

tests/utils/stl/test/params.py Outdated Show resolved Hide resolved

CaseyCarter and others added 2 commits October 22, 2024 19:21

Correct missing word in descriptive text

4e1b75a

Rename be_nice to beNice

e82bca1

StephanTLavavej self-assigned this Oct 23, 2024

Add a note to inform the user when psutil isn't installed.

c134f49

StephanTLavavej reviewed Oct 23, 2024

View reviewed changes

tests/utils/stl/test/params.py Outdated Show resolved Hide resolved

StephanTLavavej approved these changes Oct 23, 2024

View reviewed changes

StephanTLavavej removed their assignment Oct 23, 2024

StephanTLavavej mentioned this pull request Oct 23, 2024

Maintainer priorities #4700

Open

StephanTLavavej added test Related to test code and removed infrastructure Related to repository automation labels Oct 23, 2024

StephanTLavavej self-assigned this Oct 23, 2024

StephanTLavavej merged commit 27973ad into microsoft:main Oct 24, 2024
39 checks passed

CaseyCarter deleted the test-prio branch October 24, 2024 16:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add LIT parameter `priority` #5032

Add LIT parameter `priority` #5032

Uh oh!

CaseyCarter commented Oct 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

CaseyCarter commented Oct 23, 2024

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

Uh oh!

StephanTLavavej commented Oct 24, 2024

Uh oh!

Uh oh!

Add LIT parameter priority #5032

Add LIT parameter priority #5032

Uh oh!

Conversation

CaseyCarter commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

CaseyCarter commented Oct 23, 2024

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

StephanTLavavej commented Oct 23, 2024

Uh oh!

Uh oh!

StephanTLavavej commented Oct 24, 2024

🐈‍⬛ 📹 📺

Uh oh!

Uh oh!

Add LIT parameter `priority` #5032

Add LIT parameter `priority` #5032

CaseyCarter commented Oct 23, 2024 •

edited

Loading