| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 05:09:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=473.345813,conversation_content-fragment;desc="conversation_content fragment";dur=735.099553,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=475.689346,nginx;desc="NGINX";dur=1.240083,glb;desc="GLB";dur=102.385176
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=GiTnyEa8SEejJAFdtBHqBryp%2F3g9%2FoySjtz3Q6kFP4XW3s5pOys8rBLh2mc0j4fZ3njesBpaIZ1kHOl37kW7YoMfY5RW0yum6hJMWy%2FtO%2BmsVya6SwaM1dv8mbZWEPHiQHFEmXp4lFLr%2BRp0kfnhm0E%2FecHutMQVjABIgOSQZKex8hYXm5jBs69qtqE13%2FtH9lybnrONhPCvFEdEEZKRgmYJa1VmME6GmwzcF%2B9dbpOxrV3bjpX1%2FAUWuvxsJOK6cnHVhfYukii%2Boi2eGE39ng%3D%3D--O4Y%2Fi%2F8f3HYbLIoK--HSAb%2BmGtdKL2UcN%2BWHJvkA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.22214407.1753333766; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:09:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:09:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9CDC:18BEF9:3A5044:4ED223:6881C006
Don't throw arbitrary iterators at `sized_sentinel_for` by CaseyCarter · Pull Request #5027 · microsoft/STL · GitHub
Don't throw arbitrary iterators at
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Don't throw arbitrary iterators at sized_sentinel_for
#5027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split `_Idl_distance` into Ranges and pre-Ranges flavors. Who put their Ranges in my peanut butter??!? * Move `_STD _Idl_dist_min` into `ranges` for consistency. Fixes VSO-2285862 and VSO-2285916.
|
Hahaha - I noticed the missing namespace-closing comment in the internal PR without having run clang-format outside of my brain. 🧠 💯 🧙♂️ |
VS Code has been driving me nuts the last couple of updates deciding to not format-on-save seemingly at random. I suppose I shouldn't complain, I at least figured out how to stop the C++ extension from deciding |
microsoft#5015 unskipped these, they now go through the same old codepath.
StephanTLavavej
approved these changes
Oct 20, 2024
|
Thanks for fixing this up! 🛠️ 🪄 🐈⬛ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
_Idl_distanceinto Ranges and pre-Ranges flavors. Who put their Ranges in my peanut butter??!?_STD _Idl_dist_minintorangesfor consistency.Fixes VSO-2285862 and VSO-2285916. (Currently validating.)
This is a mirror of MSVC-PR-586447. (I created the mirror PR early so I can verify this fixes things that #5015 broke in RWC.)