You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please edit your PR title to describe (very briefly) what your change is doing - mentioning issue numbers there is not useful. PR titles become part of git history (e.g. see git log or the graphical gitk), and a long series of "solve issue #nnnn" is completely opaque. "Update list to remove bogus strengthened comment" would be perfectly descriptive, or you can phrase it another way.
Please edit your PR description to use GitHub's fix/close/resolve syntax so that your PR is properly linked to the issue that it resolves. "Fixes #nnnn", "Resolves #nnnn", or "Closes #nnnn" are all fine.
If you are trying to do commit using web interface only then I want to tell that this is generally not a path forward.
Whereas you may be able to finish this change this way, it doesn't let you get any further, when you have to test and validate your changes locally. I recommend you learning how to use a Git/Github client and following README.md steps to build this locally.
(I admit I have done some web commits on my own, but the purpose of good first issue is for a contributor to learn the workflow; using web interface defeats this purpose)
If you are trying to do commit using web interface only then I want to tell that this is generally not a path forward. Whereas you may be able to finish this change this way, it doesn't let you get any further, when you have to test and validate your changes locally. I recommend you learning how to use a Git/Github client and following README.md steps to build this locally.
(I admit I have done some web commits on my own, but the purpose of good first issue is for a contributor to learn the workflow; using web interface defeats this purpose)
sure sir, actually i tried with some online clang formatters(they have shown that code is formatted correctly) and some vs code extensions, but haven't looked in depth
will try now and update by end of the day
thanks for your suggesions :-)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5020.