| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:17:41 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=341.737322,conversation_content-fragment;desc="conversation_content fragment";dur=871.520302,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=453.738579,nginx;desc="NGINX";dur=1.322002,glb;desc="GLB";dur=101.331013
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=lHL5vtTyJKS5bOTqToOv0vqEZjcgMb2F8L6KJV4pt0OCPPLk8Aoj336W5QlDoI%2Bkm0Ql6rBiTB2%2F67oiAk1YWAATwO0bLwDkwt3DfIX67c3FlHGDuIVYAs%2BVOzzFANXdyf7AkDSklySAC4rN4hbISb2qB9VgTvszP%2BkU8VZ5ldvKPEh2gCakTlX4bxbGVvnPlYudfWdnVh0qJcyuzliMZaeMstR%2BHiskyYg3BDXj2XVJxgW2Q9hTZEg0F3KnZmakHticOV%2Flpb8vAqGy8a1Erg%3D%3D--5HPcNT2HnSiglWBI--Sy6ardmDv8pNTZhKp072fg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.355330143.1753298260; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:17:40 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:17:40 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D1A8:35EBF4:1032A42:1330741:68813554
Add visualizer for `std::chrono::system_clock::time_point` by Nerixyz · Pull Request #5005 · microsoft/STL · GitHub
Add visualizer for
Add visualizer for
Nerixyz
force-pushed
the
feat/chrono-timepoint-natvis
branch
from
October 8, 2024 18:38
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add visualizer for std::chrono::system_clock::time_point
#5005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 1 commit into
microsoft:main
from
Nerixyz:feat/chrono-timepoint-natvis
Oct 21, 2024
Merged
Add visualizer for std::chrono::system_clock::time_point
#5005
StephanTLavavej
merged 1 commit into
microsoft:main
from
Nerixyz:feat/chrono-timepoint-natvis
Oct 21, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes - I updated it to use decimal formatting. |
Nerixyz
force-pushed
the
feat/chrono-timepoint-natvis
branch
from
fb061d7 to
c4bac42
Compare
StephanTLavavej
approved these changes
Oct 8, 2024
| <Intrinsic Name="era" Expression="(z() >= 0 ? z() : z() - 146096) / 146097"/> | ||
| <Intrinsic Name="doe" Expression="(unsigned)(z() - era() * 146097)"/> | ||
| <Intrinsic Name="yoe" Expression="(doe() - doe()/1460 + doe()/36524 - doe()/146096) / 365"/> | ||
| <Intrinsic Name="doy" Expression="doe() - (365*yoe() + yoe()/4 - yoe()/100)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change requested: Stylistically, I would have put spaces around all binary operators, as we do in product code (enforced by clang-format). But I can see an argument for the choices here, and I'm not picky enough about visualizer syntax for it to be worth resetting testing.
|
Thanks, this is awesome! 😻 It didn't matter for this PR, but for the future - we recommend against force-pushing after review has begun, as GitHub makes it more difficult to see what's incrementally changed. (Force-pushing is okay if there's a solid reason for it, like reorganizing commits to make them comprehensible, or if review hasn't started yet.) |
CaseyCarter
approved these changes
Oct 21, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this significant improvement - and congratulations on your first microsoft/STL commit! 🎉 😻 🚀 I've filed a followup issue because we need to "triple-mirror" this change into the VS repo in order for it to actually take effect in the IDE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Adds a visualizer for
std::chrono::system_clock::time_point. To compute the date representation, it uses the same algorithm as_Civil_from_days(with the same "variables" as https://howardhinnant.github.io/date_algorithms.html#civil_from_days).The time is displayed as hh:mm:ss.ssssss. Additionally, the visualizer shows
ns/100(the actual value of the time-point),us,ms, ands.Unfortunately, the format specifiers don't provide a way of formatting numbers with padding, so they're formatted "manually" (e.g. a 2-digit
vis formatted as{v/10}{v%10}).See also: #314