You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly because of that numeric_limits<FP> are implemeted as full specializations, when one attempts use min() or epsilon(), Clang emits warning for Nan and Inf related functions, even if these functions are not themselves called.
This PR suppresses -Wnan-infinity-disabled in <limits> and <cmath> locally to avoid such false positives. When a user explicitly calls infinity(), quiet_NaN(), or signaling_NaN(), the warning is still triggered (Godbolt link).
frederick-vs-ja
changed the title
<limits>: Locally disable -Wnan-infinity-disabled for Clang<cmath>, <limits>: Locally disable -Wnan-infinity-disabled for Clang
Sep 29, 2024
The reason will be displayed to describe this comment to others. Learn more.
Suppressing these warnings at template parse time while allowing them at instantiation is an excellent solution. I didn't know this was possible before.
Thanks! 😸 ♾️ @CaseyCarter I pushed a macro refactoring after you approved, moving them to <yvals_core.h> below our usual Clang suppression macros, using the same escape-hatch pattern (just in case), and recording the warnings that they're suppressing in comments.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4931.
Possibly because of that
numeric_limits<FP>
are implemeted as full specializations, when one attempts usemin()
orepsilon()
, Clang emits warning for Nan and Inf related functions, even if these functions are not themselves called.This PR suppresses
-Wnan-infinity-disabled
in<limits>
and<cmath>
locally to avoid such false positives. When a user explicitly callsinfinity()
,quiet_NaN()
, orsignaling_NaN()
, the warning is still triggered (Godbolt link).