| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:25:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=424.270972,conversation_content-fragment;desc="conversation_content fragment";dur=842.522414,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=462.115441,nginx;desc="NGINX";dur=0.712869,glb;desc="GLB";dur=100.702807
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=bDbPY%2B2CkvpJ%2Fw6L5%2FYOjnjARXZ9UkVtbVQuNq%2B3wEWveWNqpwB92iJW%2BQXuJ9hl3cUaEpvXXgJPwuGTGjJCsT4Qd4DMG2KcI7gQUbZDafN%2BZdFF9lsymeLDl4qWg%2BmkhWBgQQaugK8RhLRSewHbsffbFW8%2BwzQv5tvMkWNUyixdV6bMUj0TMZlE6YBdDkwV%2BKVJ2%2B59JIiSz5AouOAn1qYaqREwEA50ViE6utsDfor1cxszeda%2ByxrEkBX2uGqO6VajfvgGPfyMEmEfoeKJSQ%3D%3D--lfJ1mxNvmIu2TJE8--j1neIJoCiyxTppShc752ng%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.700733833.1753298713; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:25:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:25:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 82B8:3B93B0:104F65C:1351083:68813719
`<vector>`: More scope guards by frederick-vs-ja · Pull Request #4977 · microsoft/STL · GitHub
frederick-vs-ja
force-pushed
the
vector-scope-guards
branch
2 times, most recently
from
September 23, 2024 12:03
frederick-vs-ja
force-pushed
the
vector-scope-guards
branch
from
September 23, 2024 12:32
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<vector>: More scope guards
#4977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 3 commits into
microsoft:main
from
frederick-vs-ja:vector-scope-guards
Oct 12, 2024
Merged
<vector>: More scope guards
#4977
StephanTLavavej
merged 3 commits into
microsoft:main
from
frederick-vs-ja:vector-scope-guards
Oct 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
vector-scope-guards
branch
2 times, most recently
from
3a167a2 to
dbd409f
Compare
There're still two occurrences of try-catch-reraise in `_Insert_counted_range`, which don't seem able to be replaced by scope guards if we want to keep the current behavior. It seems that no more `_RERAISE;` in other headers can be replaced with scope guards. Drive-by: strengthening exception specification for - `allocator<T>::deallocate`, - `allocator_traits<allocator<T>>::deallocate`, and - `vector<T, A>::_Change_array`.
frederick-vs-ja
force-pushed
the
vector-scope-guards
branch
from
dbd409f to
2f45105
Compare
StephanTLavavej
approved these changes
Oct 3, 2024
|
Thanks, this is a very clean transformation! 🪄 I pushed a conflict-free merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks again for improving the STL's bestest data structure! 💯 ⭐ 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Towards #2307. Possibly closes it?
There're still two occurrences of try-catch-reraise in
_Insert_counted_range, which don't seem able to be replaced by scope guards if we want to keep the current behavior. It seems that no more_RERAISE;in other headers can be replaced with scope guards.Drive-by: strengthening exception specification for
allocator<T>::deallocate,allocator_traits<allocator<T>>::deallocate, andvector<T, A>::_Change_array.