CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:25:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=358.511251,conversation_content-fragment;desc="conversation_content fragment";dur=591.561521,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=497.51582,nginx;desc="NGINX";dur=1.15433,glb;desc="GLB";dur=100.953274
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=kwPZ7VOvkPoSiYnSDn%2BHQjs%2BNW43SD9M8BfT5V%2BIhx7BAhtAiRblBKQbanYjVqRh%2FhyMzwo3UfS%2F2JGQvLBLu0loHlXxrXx2bu908K55O9BSBartPPg4bMrZNulV6VDgmpmgxAKffSWsdmaD9ehnedUwadWETco50OBXItYjrO%2FgLuEObYakTjr3pXqhAWzRolkYfjMuTpwXVkanoXebj4GUp1%2BVboHPBBTk1Lx2eTeWMGvvdd4DtElrKCeJimflCM1dH6%2BAiXnMIUQzDO015Q%3D%3D--LXfsb%2BQ0sL%2BnLIzr--z8jbnROwGZWkD3w4qaBqMQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.688821745.1753298712; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:25:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:25:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 82A6:12BD61:1035E07:133779D:68813718
Compiler bug workaround for using `format()` in a user-defined module by StephanTLavavej · Pull Request #4919 · microsoft/STL · GitHub
Compiler bug workaround for using
StephanTLavavej
added
bug
Something isn't working
format
C++20/23 format
modules
C++23 modules, C++20 header units
labels
Aug 27, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Compiler bug workaround for using format()
in a user-defined module
#4919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified that without the product code workaround, this fails with: D:\GitHub\STL\out\x64\out\inc\format(2635): error C3688: invalid literal suffix 'sv'; literal operator or literal operator template 'operator ""sv' not found D:\GitHub\STL\out\x64\out\inc\format(2637): error C3688: invalid literal suffix 'sv'; literal operator or literal operator template 'operator ""sv' not found D:\GitHub\STL\out\x64\out\inc\format(2639): error C3688: invalid literal suffix 'sv'; literal operator or literal operator template 'operator ""sv' not found D:\GitHub\STL\out\x64\out\inc\format(2641): error C3688: invalid literal suffix 'sv'; literal operator or literal operator template 'operator ""sv' not found D:\GitHub\STL\out\x64\out\inc\format(2644): error C3688: invalid literal suffix 'sv'; literal operator or literal operator template 'operator ""sv' not found Perl also tested positively and negatively.
CaseyCarter
approved these changes
Aug 27, 2024
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
DevCom-10313766 VSO-1775715 "Using
std::format
in a module requires including<format>
header in .cpp files using that module" is caused by a compiler bug where the compiler is currently unable to encode UDLs in the IFC. The workaround is to avoid UDLs. Constructing temporaries of length 2 or 1 was the simplest, compared to extracting namedconstexpr
variables.Since the workaround is relatively simple but affects several lines, I chose to make it unconditional (instead of guarding it for MSVC only), and I commented only the first occurrence (no reason to repeat it on every line). My hope is that the compiler will be fixed very soon (@cdacamar is investigating).
I audited the STL for other UDLs in our headers, and
<filesystem>
was the only other user of UDLs. However, all of its usage was in non-templated functions, which appear to be immune to the compiler bug, so I don't believe that<filesystem>
changes are necessary.This scenario, where the STL is included in the Global Module Fragment of a user-defined module, is clearly under-explored - along the way I encountered and reported the much more severe VSO-2227713 "Modules: Exported function templates can't use
std::cout
properly" (with no known workaround). So, I'm adding a dedicated test for this scenario, currently just exercising theformat()
scenario but available to extend in the future. I had to extractP2465R3_standard_library_modules/env.lst
(because we have to handle the usually-force-included machinery specially, and can't tolerate/permissive
, we need dedicated configurations).This requires special Python and Perl machinery to compile the
user.ixx
before thetest.cpp
, but very similar to existing tests that we have elsewhere. I verified both the GitHub Python and internal Perl test harnesses, both positively (test passes with product changes) and negatively (test fails without product changes).