You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Visual Studio IDE has an "inline parameter hint" feature which will show the parameter names inline. The STL generally has nice descriptive names which can make this feature helpful.
When I went to use views::iota I forgot if the second arg is a count or not, I was hoping the parameter names would save me a trip to cppreference, but alas, I was greeted with useless names.
views::repeat has the same issue (which is my fault; I just copied and pasted iota)
I also have a feature request to de-uglify them (might make another to not show the type information for these views, or I guess more generally, long nested templated types)
Thanks! π» This is a strict improvement over the status quo's currently terrible names, so I'm happy here.
I observe that this isn't perfectly consistent with either the underlying views' parameters, or the Standard-depicted parameters, but I don't care enough to nitpick it further. (The views are the preferred interface for users, and the names you've chosen are a bit more descriptive than "value, bound", which is enough rationale for me.)
I observe that this isn't perfectly consistent with either the underlying views' parameters, or the Standard-depicted parameters, but I don't care enough to nitpick it further. (The views are the preferred interface for users, and the names you've chosen are a bit more descriptive than "value, bound", which is enough rationale for me.)
After I made the commit I realised the same thing... I then also came to pretty much the same conclusion so opted to just create the PR anyway π.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Visual Studio IDE has an "inline parameter hint" feature which will show the parameter names inline. The STL generally has nice descriptive names which can make this feature helpful.
When I went to use
views::iota
I forgot if the second arg is a count or not, I was hoping the parameter names would save me a trip to cppreference, but alas, I was greeted with useless names.views::repeat
has the same issue (which is my fault; I just copied and pasted iota)I also have a feature request to de-uglify them (might make another to not show the type information for these views, or I guess more generally, long nested templated types)