CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 05:08:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=352.921633,conversation_content-fragment;desc="conversation_content fragment";dur=583.819637,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=364.071594,nginx;desc="NGINX";dur=1.274427,glb;desc="GLB";dur=102.885409
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=samCgbzjCTtQuUW7B5a83sWLfrN0O8YIWn9Xzm%2FN0BSLbLHz%2BUC6tEmuglkFcOZCBogxHLAdzcbaoprIjPraLwZNDVHV27brs%2FAvu5khh%2FFb8rBpaNqHmWMx9gjjHPNVXnRt7USetUz66J019ao8huxwGlvW7X6VdMudrxr%2BDR2Wo8SvYHzwbhQQLh%2FI51Gg4XacaWat99yMpHV3oc7OtbLA1q4Q2vt3XKV3ylsvpK8Kv%2BmJuL5eStlt8cc1DwZ6cKWV%2FCE2LRMWskV6GUKtXw%3D%3D--Jh92KJfAuA2ZXiWl--XZzQLYAbHIkbjGk5ntOj9A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.578326474.1753333737; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:08:57 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:08:57 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E65E:0A62:260404:33C010:6881BFE9
Fix and improve `array` and `mdspan` static analysis warnings by StephanTLavavej · Pull Request #4856 · microsoft/STL · GitHub
Fix and improve
Fix and improve
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix and improve array
and mdspan
static analysis warnings
#4856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 7 commits into
microsoft:main
from
StephanTLavavej:annotate-array-size
Aug 8, 2024
Merged
Fix and improve array
and mdspan
static analysis warnings
#4856
StephanTLavavej
merged 7 commits into
microsoft:main
from
StephanTLavavej:annotate-array-size
Aug 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barcharcraz
approved these changes
Jul 31, 2024
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
I had to push an additional commit to skip a libcxx test which is running out of compiler memory under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
🗺️ Overview
Fixes DevCom-10342063 VSO-1804139 "False positive C28020 iterating over single element
std::array
". Thanks to Hwi-sung Im from the static analysis team for explaining how to fix this with_Ret_range_(==, _Size)
.The issue is that we had SAL annotations on
array::operator[]
explaining its precondition, but static analysis didn't know thatarray<T, N>::size()
always returnsN
. (By design, it doesn't do interprocedural analysis.) Adding a return annotation allows/analyze
to understand loops that are guarded byarr.size()
.Updating
array
then revealed that<mdspan>
(which usesarray
extensively) should be updated accordingly.📜 Commits
array::size()
with_Ret_range_(==, _Size)
, which is what fixes the reported bug._In_range_(0, _Size - 1)
with_In_range_(<, _Size)
. I wasn't previously aware of this form, but it appears elsewhere in the MSVC codebase, and is much more natural as it aligns with our_STL_VERIFY
checks.array
and<mdspan>
below, we're always working withsize_t
, so we don't need to worry about negative numbers.<mdspan>
, update a comment from citing DevCom-923103 to saying "guaranteed by how_Rank_dynamic
is calculated". We have an ironclad guarantee here, but the proof is way more subtle than static analysis can reasonably be expected to understand, so this isn't a compiler bug workaround.rank()
with_Ret_range_
andstatic_extent()
,extent()
, andstride()
with_In_range_
.layout_stride::mapping::stride()
.mdspan::extent()
isn't missing a check, it's just performed bythis->_Map.extents().extent(_Idx)
and the message will be sufficiently relevant._In_range_(<, _Rank)
.FAIL
, but one needs to be added (because we have more precondition annotations).test_mdspan_support.hpp
, addassert(i < rank)
so static analysis is happy with the precondition. (Attempting to propagate the annotation to the lambda led to more warnings, since it's used withinvoke()
andiota_view
.)Ext::rank()
is now understood.P0009R18_mdspan_layout_stride
to useExt::rank()
instead of the equivalentstrs.size()
so/analyze
can see the guarantee.P0218R1_filesystem
, theEXPECT
macro calls a function that returns the givenbool
, but/analyze
doesn't see that, so it doesn't realize we're checking the validity ofindex
. Restructure this with a direct test andEXPECT(false)
(which will still result in decent logging since the line number is captured)./analyze
warning when intentionally making out-of-bounds calls. I mention/analyze
instead of the internal "PREfast" terminology here.suppress
withpush
/disable
/pop
, as we've already completely done in the product code, sincesuppress
is annoyingly fragile and we should avoid it, despite the additional lines needed to push/disable/pop.