CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 04:54:01 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
cache-control: no-cache
etag: W/"31a6ea07fd0fce8ab7f3a8b66f2669ca"
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=h5QzkLsvsDAW3DV%2FOeJufHcHta4USUB3WYFRElETwJOApZ%2FiPG9jppS%2FSmkRiOntxrSBeHjo0mRHk4XXjf%2BHx0VUK%2B1Vv693h2%2BLyQOBV1ca%2BbO3jMz38O38ITw2yIpfX9Zyv4nMJ0vvlIcKCmJq43NO0G3nTvq4%2BKTynObgYTqEh%2BnAVTtCKds9WvXGTPg%2FwljjC5qA8iifsN6pCiuYWwqD4RBMNrBXiYYu5G3U79tJFEEOgSDtf15wFym%2FvF0wZIcIAePMtR4xa1rLK7BM1g%3D%3D--rlFtvOyOBnzedbvj--T2%2B%2FHXcevX%2BOaYiOlGY4Sg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.54819921.1753332840; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:54:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 04:54:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E39E:3F8A98:35EFB9:49E61C:6881BC68
Fix `filesystem::weakly_canonical()` on Win11 24H2 by StephanTLavavej · Pull Request #4844 · microsoft/STL · GitHub
Fix
StephanTLavavej
added
bug
Something isn't working
high priority
Important!
filesystem
C++17 filesystem
labels
Jul 19, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix filesystem::weakly_canonical()
on Win11 24H2
#4844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding policy as @zacklj89 approved the internal mirror MSVC-PR-566203. |
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
We have a regression test for DevCom-538510 (internal VSO-850856) "
std::filesystem::weakly_canonical
erroneously throws an exception":STL/tests/std/tests/P0218R1_filesystem/test.cpp
Lines 3233 to 3237 in ecbc1ef
This has regressed on the upcoming Win11 24H2, where we throw an exception (again). The relevant code is:
STL/stl/inc/filesystem
Lines 4127 to 4144 in ecbc1ef
After calling
_Canonical()
, anything other than_Err == __std_win_error::_Success
or__std_is_file_not_found(_Err)
is considered a hard error (which will cause the non-error_code
overload to throw afilesystem_error
).In current OSes, the
fileWithSuffix
scenario results in_Invalid_name
here. (Locally verified on Win11 23H2. Presumably we get the same behavior in the GitHub PR/CI system running Server 2022 21H2, although I didn't verify that.)In Win11 24H2, we get
_Directory_name_is_invalid
, which isn't recognized by__std_is_file_not_found
. đź’ĄThe fix is backwards-compatible and a simple one-liner: add this error code enumerator to the list of synonyms that
__std_is_file_not_found
recognizes. The plain meaning of_Directory_name_is_invalid
is clearly a subset of_Invalid_name
.I've manually verified this (with significant but perhaps not surprising logistical difficulty) in an Azure VM with Win11 24H2. Regular test coverage will be provided by the MSVC-internal test harness (which is how we found this), and eventually by the GitHub test harness once Server 2025 24H2 is officially released.
Additionally, this uncaught exception from a non-
error_code
overload manifested itself as anabort()
with no useful logs. To aid in future investigations, I'm including a simple change to the filesystem test. Now, we wrap the whole test intry ... catch
and print the contents of any exception before failing.