| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:22:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=396.503805,conversation_content-fragment;desc="conversation_content fragment";dur=1375.318732,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=443.132627,nginx;desc="NGINX";dur=0.756734,glb;desc="GLB";dur=102.719756
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=UhvEYBQHj0hQLWQSWbg4AxiGOomCo%2BG6Vcluxhs3MXanmeqJhxHfErlrgCBwPrp6eLGk8JigHGZhkPWEKz6Ks9rAW1nIrNQelUIc2EwOO3hYNpfjgQKSrwNW4uailRZE9nOnsGOKuooUojUIh5MaGROkB%2BKp5YwZZIHSfp%2BWi6XfI5I6tOE%2BDpliKLiE3gg9zPzTMrWZ%2F3Du9JpyVslh26DZWhMHkIGvaUhM14LnRArwjkHJA11eadUZXJcskf3gr1sspWPUxw8aNZesB1b2rQ%3D%3D--BUOhiJUxsUUQQpr8--UtuqEAqbeBGYKb48N4To%2Fg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.625274364.1753298524; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:22:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:22:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9CB2:EE750:7059B:8CEA8:6881365C
`<numeric>`: check for gcd / lcm overflows by AlexGuteniev · Pull Request #4776 · microsoft/STL · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<numeric>: check for gcd / lcm overflows
#4776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In compile time or in debug. Applies to C++20 and later mode.
AlexGuteniev
commented
Jul 1, 2024
frederick-vs-ja
approved these changes
Jul 2, 2024
`_Mul_overflow` is made to only handle non-`bool` integer types in C++17.
Backport overflow checking of `lcm`/`gcd` to C++17
StephanTLavavej
approved these changes
Jul 9, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
numeric: Add a `static_cast` when dividing `_Common_unsigned` by `_Common_unsigned`, due to the usual arithmetic conversions which will emit sign conversion warnings for tiny types. utility: * Move `_Is_standard_integer` down to the `_HAS_CXX20` region. (It's also used by `<mdspan>`.) * Relax the internal `_Cmp_equal`, `_Cmp_less`, and `_In_range` to accept nonbool integrals. + Because they're internal, we can `_STL_INTERNAL_STATIC_ASSERT`. + Comment that this "allows character types". * Enforce `_Is_standard_integer` at the user-visible layer. P0295R0_gcd_lcm: Add test coverage, because gcd/lcm are required to accept nonbool integrals. (An MSVC-internal test found this by using `char`.)
|
I pushed a commit: Fix gcd/lcm to work with all nonbool integrals. numeric: Add a utility:
P0295R0_gcd_lcm: Add test coverage, because gcd/lcm are required to accept nonbool integrals. (An MSVC-internal test found this by using |
StephanTLavavej
approved these changes
Jul 11, 2024
AlexGuteniev
commented
Jul 11, 2024
| @@ -883,38 +876,56 @@ _NODISCARD constexpr bool _In_range(const _Ty _Value) noexcept { | |||
| } | |||
|
|
|||
| #if _HAS_CXX20 | |||
| template <class _Ty> | |||
| constexpr bool _Is_standard_integer = _Is_any_of_v<remove_cv_t<_Ty>, signed char, short, int, long, long long, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be useful to comment that this can be used to test for standard and extended integer types, because there are no extended integer types (probably in a subsequent change)
|
Thanks for implementing these checks! My internal branch was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In compile time or in debug.
Fixes #2300