You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the "use the bitmap" and "couldn't use the bitmap" codepaths
always return, we can positively test for "use the bitmap".
This is a clarity improvement all by itself - it's easier
to understand "if we can do cool thing, do it".
The assignment `_Use_bitmap = false;` is guarded by `_Try_vectorize && (STUFF)`.
So when we skip using the bitmap, the later condition `if (_Try_vectorize)` is guaranteed to be active.
I had the assumption that _Special is the case where we definitely have one of the standard character types. But apparently char_traits can be specialized for custom character types, so _Special may be true for something not behaving as a character.
It seems that we should fix _Special for all _Traits_meow algorithms. Perhaps in another PR?
(Also, it's possibly better to make _Special not a template parameter, which would shorten mangled names.)
It seems that we should fix _Special for all _Traits_meow algorithms. Perhaps in another PR?
Yes, I think I can do this some time later (If you or someone else won't do it before me).
I'd prefer keeping the current PR draft, until it can be merged with main containing the changes of that PR.
This way basic_string won't become more broken for odd character types.
(Also, it's possibly better to make _Special not a template parameter, which would shorten mangled names.)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4497