CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 05:19:48 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=292.668581,conversation_content-fragment;desc="conversation_content fragment";dur=1523.068704,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=315.482539,nginx;desc="NGINX";dur=0.734927,glb;desc="GLB";dur=101.403915
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=sGZE9E%2F2fg%2FdOiqhVLh0J1dglbDAuaPspS81UvsrZ1KjhR%2FvSwagGuSTnD3KVn7D2WL5V0VSdDBpPKvz7aFo1pH9Hm8oI%2FodzF7ugLqfQFkO3eMVJdiRSIMHyR1ZyrFvbP2AHoJlZSzk4I0LmRZ63y%2FVz6YP5gUqlIu2mCuH5V7DCwrk6NyyBfYn1oQ%2B9HN18dRv7dmls0nVon1P1jJ7Ri47%2B1RqyiffFtt6LpRAyZ8wPbhKIt0tnqKwVdGeeII3Ek9xstzHS7STABxMqkNClA%3D%3D--yO5jJ6ZBqsWxBXdM--LUjXoqRTn3Ji%2B5aww3anuQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1448900915.1753334386; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:19:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 05:19:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D4BC:3AEC1B:3C929E:5155C5:6881C272
Build the x86 STL with `/arch:SSE2` instead of `/arch:IA32` by StephanTLavavej · Pull Request #4741 · microsoft/STL · GitHub
Build the x86 STL with
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Build the x86 STL with /arch:SSE2
instead of /arch:IA32
#4741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2024
barcharcraz
approved these changes
Jun 21, 2024
jieyouxu
added a commit
to jieyouxu/cc-rs
that referenced
this pull request
Feb 27, 2025
- Official Rust Windows targets require `SSE2` as part of baseline target features. - STL is built with `/arch:SSE2` and no longer `/arch:IA32` since <microsoft/STL#4741>. This was noticed in rust-lang/rust CI for `i686-pc-windows-msvc` `rustc_llvm` builds because `__m128i` wasn't available, and we suspected it was due to `/arch:IA32`.
jieyouxu
added a commit
to jieyouxu/cc-rs
that referenced
this pull request
Feb 27, 2025
- Official Rust Windows targets require `SSE2` as part of baseline target features. - `i586` Windows target without SSE2 is in process of being removed, so wasn't changed in this commit. - STL is built with `/arch:SSE2` and no longer `/arch:IA32` since <microsoft/STL#4741>. This was noticed in rust-lang/rust CI for `i686-pc-windows-msvc`, where `rustc_llvm` builds failed because `__m128i` wasn't available, and we suspected it was due to `/arch:IA32`.
ChrisDenton
pushed a commit
to rust-lang/cc-rs
that referenced
this pull request
Feb 27, 2025
- Official Rust Windows targets require `SSE2` as part of baseline target features. - `i586` Windows target without SSE2 is in process of being removed, so wasn't changed in this commit. - STL is built with `/arch:SSE2` and no longer `/arch:IA32` since <microsoft/STL#4741>. This was noticed in rust-lang/rust CI for `i686-pc-windows-msvc`, where `rustc_llvm` builds failed because `__m128i` wasn't available, and we suspected it was due to `/arch:IA32`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #3118. Fixes #3922. See
/arch
(x86) on Microsoft Learn.On x86, the STL (and indeed the entire VCRedist) was historically built with
/arch:IA32
because it had to be capable of running on ancient OSes and potato chips. Now, Win7 / Server 2008 R2 are unsupported and no longer receiving security updates - but before they reached end-of-life, even they were patched to require SSE2. That was KB4103718 in May 2018, over 6 years ago. (Note: I am well aware of the single exception that paid security updates for the highly obscure Windows Embedded POSReady 7 will end in Oct 2024. More on that in another PR, but the point here is that even Windows 7 requires SSE2 now.)The STL can now begin assuming unconditional support for SSE2. The compiler now defaults to
/arch:SSE2
, so all we need to do is remove/arch:IA32
.Why make this change? It slightly simplifies our build system and may slightly improve performance (although I don't expect it to be observable, so the PR label is honorary). It also means that our separately compiled code will be exercising the same compiler codepaths used by the vast majority of x86 builds everywhere. If the status quo were reversed and we were currently building with
/arch:SSE2
, we would never want to change to/arch:IA32
.This affects the VCRedist, but (1) VS 2022 17.12 will be an "unlocked" long-term support release, and (2) there are no coordinated header changes, so we don't need to worry here.
Note that although we can now assume that SSE2 is unconditionally available (as it has always been for x64), we aren't taking advantage of that in manually vectorized algorithms. See #4536 - attempting to maintain distinct codepaths for SSE2 and SSE4.2 was extremely difficult and we no longer take that risk.
We can also drop test coverage that disables SSE2 (in a partial, simulated way), because we'll never run on such processors.
Finally, I don't think we need to bother testing
GH_000935_complex_numerical_accuracy
with/arch:IA32
. The STL's headers aren't blocking the option, so while users must be running SSE2-capable processors, they can still limit their own codegen to IA32 (unless and until the compiler deprecates and removes the option, of which I am aware of no plans). However, I think this option is sufficiently obscure that we don't need to bother testing it, and we haven't had any bugs involving it either.