You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated build compiler to VS 2022 17.11 Preview 2.
Updated Python to 3.12.4.
💡 Notes
The internal build compiler still needs to be updated (@MahmoudGSaleh is working on it, but it's a time-consuming process), so we still can't require _MSC_VER1941.
Similarly, a new WinSDK is available, but the internal build isn't using it yet, so I'm not updating the image or the readme to specify it. (This is updated at a slower pace, so it might not happen for a while.)
That's a good question! (And one that I didn't fully think through before submitting this PR 😹)
In this case I think I'll get away with all of these workaround removals. EDG is updated independently from the checked-in MSVC toolset, and is actually usually a newer version than what's shipping publicly, so the EDG workaround removals should be fine. The <limits.h> workaround removal depends on updated VCRuntime sources that I fixed, which are present in the internal repo (they aren't consumed from the checked-in toolset). So that leaves the ASAN issue, which I think will be okay - the checked-in toolset is used only for the initial build, whereas the tests run with the freshly built compiler. Even though we're building the compiler with ASAN these days (or will shortly, I forget), this bug was specific to the static debug STL, but the compiler doesn't consume the STL statically.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Changelog
💡 Notes
The internal build compiler still needs to be updated (@MahmoudGSaleh is working on it, but it's a time-consuming process), so we still can't require
_MSC_VER
1941
.Similarly, a new WinSDK is available, but the internal build isn't using it yet, so I'm not updating the image or the readme to specify it. (This is updated at a slower pace, so it might not happen for a while.)
STL-ASan-CI passed.
⚙️ Workarounds removed
<limits.h>
emits warning C4668"static_assert(false)
usable"<type_traits>
.std::num_get
"