| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 19:59:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=332.791705,conversation_content-fragment;desc="conversation_content fragment";dur=1323.368794,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=452.924959,nginx;desc="NGINX";dur=0.891412,glb;desc="GLB";dur=101.667486
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=fyaRAZ7BODikM8LHVi6g39OLTpdeO53Y0lluQygVKzw%2BsM38DUVfHSKpV8HvJWPdOA%2B08L8L1FJlA1KgRElXxX0oX3g5qkmbw%2Bu0sCzbYkalhXu9U5P13Hj4JRsLOZceyFsqrEv8qhgy1e0lxOBJftO4pKOb9jKJdC%2Fu1YINEYgnC5RFXzUdOh4xEk9lJw%2Bg8BbfygghqRlWGas62XFNW8ED8eXm6icfcSfiL6ihKKXJ%2Fk%2FpdIKktgwzx4mcVicTQfASXCW4RKbNtQi3ctO9gw%3D%3D--xI%2FW1Szf1aSpnvdB--IEkGVC3l%2FdchybPLRZafyQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1092755843.1753300777; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:59:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 19:59:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E6C6:124FF4:10684B9:137B511:68813F29
Implement `range-default-formatter` by frederick-vs-ja · Pull Request #4716 · microsoft/STL · GitHub
Implement
Implement
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
2 times, most recently
from
June 9, 2024 04:17
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
from
June 9, 2024 05:40
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
from
June 9, 2024 13:20
StephanTLavavej
added
ranges
C++20/23 ranges
format
C++20/23 format
cxx23
C++23 feature
labels
Jun 9, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement range-default-formatter
#4716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 13 commits into
microsoft:main
from
frederick-vs-ja:range-default-formatter
Jun 27, 2024
Merged
Implement range-default-formatter
#4716
StephanTLavavej
merged 13 commits into
microsoft:main
from
frederick-vs-ja:range-default-formatter
Jun 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
2 times, most recently
from
af2c18c to
a86faaf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
from
a86faaf to
065f92c
Compare
|
There are a lot of code movements. To make code review easier, can you split them into a separate commit? |
The following tests are derived from libc++'s test files: - `P2286R8_text_formatting_range_map` - `P2286R8_text_formatting_range_sequence` - `P2286R8_text_formatting_range_set` - `P2286R8_text_formatting_range_string` Note that libc++'s `range_formatter` is currently buggy on the `m` option, see LLVM-90196 and LLVM-94562. The test `P2286R8_text_formatting_tuple_disambiguation` covers formatting `pair`s and `tuple`s that are also ranges. Unblocks libcxx tests: - `std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.format.pass.cpp` - `std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.vformat.pass.cpp` - `std/utilities/format/format.range/format.range.fmtdef/parse.pass.cpp` - `std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp` - `std/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cpp` - `std/utilities/format/format.range/format.range.fmtmap/parse.pass.cpp` - `std/utilities/format/format.range/format.range.fmtset/parse.pass.cpp` - `std/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cpp` - `std/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cpp` - `std/utilities/format/format.range/format.range.fmtstr/parse.pass.cpp` - `std/input.output/iostream.format/print.fun/includes.compile.pass.cpp`
frederick-vs-ja
force-pushed
the
range-default-formatter
branch
from
065f92c to
e0b8a30
Compare
Done. |
cpplearner
reviewed
Jun 9, 2024
Removing one improper `// exposition only` comment. Co-authored-by: S. B. Tam <cpplearner@outlook.com>
StephanTLavavej
added
ranges
tests/std/tests/P2286R8_text_formatting_tuple_disambiguation/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Jun 25, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this next step towards completing C++23! 🎉 😻 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Towards #2919/WG21-P2286R8/WG21-P2585R1.
The following tests are derived from libc++'s test files:
P2286R8_text_formatting_range_mapP2286R8_text_formatting_range_sequenceP2286R8_text_formatting_range_setP2286R8_text_formatting_range_stringNote that libc++'s
range_formatteris currently buggy on themoption, see LLVM-90196 and LLVM-94562.The test
P2286R8_text_formatting_tuple_disambiguationcovers formattingpairs andtuples that are also ranges.Unblocks libcxx tests:
std/containers/sequences/vector.bool/vector.bool.fmt/format.functions.format.pass.cppstd/containers/sequences/vector.bool/vector.bool.fmt/format.functions.vformat.pass.cppstd/utilities/format/format.range/format.range.fmtdef/parse.pass.cppstd/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cppstd/utilities/format/format.range/format.range.fmtmap/format.functions.vformat.pass.cppstd/utilities/format/format.range/format.range.fmtmap/parse.pass.cppstd/utilities/format/format.range/format.range.fmtset/parse.pass.cppstd/utilities/format/format.range/format.range.fmtstr/format.functions.format.pass.cppstd/utilities/format/format.range/format.range.fmtstr/format.functions.vformat.pass.cppstd/utilities/format/format.range/format.range.fmtstr/parse.pass.cppstd/input.output/iostream.format/print.fun/includes.compile.pass.cpp