You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't match the presets.
Without this patch, it does.
I believe that with this patch, Visual Studio sees all presets as disabled, because VS doesn't set $env{Platform}, and thus it falls back to the predefined configurations.
After looking into this deeper I'm not sure if it is even the right direction.
People were complaining about tests not building in a wrong command prompt, not the STL itself.
I'm not even sure that you can't build the STL itself this way.
For tests, we need to modify stl-lit.py, not CMake.
You can build the wrong preset in the wrong command prompt; I tested it.
How it works, for example:
You are in an x64 command prompt and you build an x86 preset. It finishes without error. It creates the out/x86 folder, but the libs would be x64.
Later, when you open an x86 command prompt and run tests from the out/x86 folder, you will get an error about a mismatch in architecture.
So I think my patch can help with these issues, partly. But we also can make a patch for stl-lit.py.
(They also support regex "matches", but (1) their regex syntax has weirdness and (2) while it would save a few lines in the JSON, it would look more complicated than the list of ["meow", ""], so I chose the simpler option.)
I re-verified enabled and disabled cases in the terminal, and that the VS IDE works (actually the first time I've built the STL in the IDE πΉ).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4639
I didn't test ARM command prompts.