Use _STL_REPORT_ERROR in headers (#5560)

AlexGuteniev · Fulgen301 · StephanTLavavej · web-flow · commit e2115badf22f · 2025-06-14T03:28:11.000-07:00
Co-authored-by: Fulgen301 &lt;Fulgen301@users.noreply.github.com&gt;
Co-authored-by: Stephan T. Lavavej &lt;stl@microsoft.com&gt;
diff --git a/stl/inc/atomic b/stl/inc/atomic
@@ -2990,7 +2990,8 @@ public:
                 break;
 
             default: // Unrecognized bit pattern
-                _CSTD abort();
+                _STL_REPORT_ERROR("atomic shared_ptr invariant broken");
+                break;
             }
         }
     }
diff --git a/stl/inc/format b/stl/inc/format
@@ -3540,7 +3540,7 @@ _NODISCARD _FormatContext::iterator _Tuple_formatter_format(const tuple<formatte
         _STD _Tuple_formatter_format_to_context(
             _Underlying, _Separator, _Opening_bracket, _Closing_bracket, _Tmp_ctx, _Args...);
     } else {
-        _CSTD abort(); // no basic_format_context object other than _Default_format_context can be created
+        _STL_REPORT_ERROR("no basic_format_context object other than _Default_format_context can be created");
     }
 
     const int _Width = _STD _Measure_display_width<_CharT>(_Tmp_str);
diff --git a/stl/inc/functional b/stl/inc/functional
@@ -770,7 +770,8 @@ private:
         auto& _Myax = _Mypair._Get_first();
         if constexpr (!is_copy_constructible_v<_Callable>) { // used exclusively for packaged_task
             (void) _Myax;
-            _CSTD abort(); // shouldn't be called, see GH-3888
+            _STL_REPORT_ERROR("this callable object should not be copied");
+            return nullptr;
         } else if constexpr (_Is_large<_Func_impl>) {
             _Myalty _Rebound(_Myax);
             _Alloc_construct_ptr<_Myalty> _Constructor{_Rebound};
@@ -808,7 +809,8 @@ private:
     }
 #else // ^^^ _HAS_STATIC_RTTI / !_HAS_STATIC_RTTI vvv
     [[noreturn]] const type_info& _Target_type() const noexcept override {
-        _CSTD abort(); // shouldn't be called, see GH-3888
+        _STL_REPORT_ERROR("type info is disabled");
+        _STL_UNREACHABLE; // no return value available for "continue on error"
     }
 #endif // ^^^ !_HAS_STATIC_RTTI ^^^
 
@@ -859,7 +861,8 @@ public:
 private:
     _Mybase* _Copy(void* _Where) const override {
         if constexpr (!is_copy_constructible_v<_Callable>) { // used exclusively for packaged_task
-            _CSTD abort(); // shouldn't be called, see GH-3888
+            _STL_REPORT_ERROR("this callable object should not be copied");
+            return nullptr;
         } else if constexpr (_Is_large<_Func_impl_no_alloc>) {
             return _STD _Global_new<_Func_impl_no_alloc>(_Callee);
         } else {
@@ -889,7 +892,8 @@ private:
     }
 #else // ^^^ _HAS_STATIC_RTTI / !_HAS_STATIC_RTTI vvv
     [[noreturn]] const type_info& _Target_type() const noexcept override {
-        _CSTD abort(); // shouldn't be called, see GH-3888
+        _STL_REPORT_ERROR("type info is disabled");
+        _STL_UNREACHABLE; // no return value available for "continue on error"
     }
 #endif // ^^^ !_HAS_STATIC_RTTI ^^^
 
@@ -1352,8 +1356,8 @@ inline constexpr size_t _Minimum_function_size = 2 * sizeof(void*);
 
 template <class _Rx, class... _Types>
 [[noreturn]] _Rx __stdcall _Function_not_callable(const _Move_only_function_data&, _Types&&...) noexcept {
-    _CSTD abort(); // Unlike std::function, move_only_function doesn't throw bad_function_call
-                   // (N4950 [func.wrap.move.inv]/2)
+    _STL_REPORT_ERROR("empty move_only_function call (N5008 [func.wrap.move.inv]/2)");
+    _STL_UNREACHABLE; // no return value available for "continue on error"
 }
 
 template <class _Vt, class _VtInvQuals, class _Rx, bool _Noex, class... _Types>
diff --git a/stl/inc/future b/stl/inc/future
@@ -1319,7 +1319,7 @@ template <class... _Types>
 class _Fake_no_copy_callable_adapter {
     // async() is built on packaged_task internals which incorrectly use
     // std::function, which requires that things be copyable. We can't fix this in an
-    // update, so this adapter turns copies into abort(). When VSO-153581 is
+    // update, so this adapter turns copies into _STL_REPORT_ERROR(). When VSO-153581 is
     // fixed, remove this adapter.
 private:
     using _Storaget = tuple<decay_t<_Types>...>;
@@ -1331,7 +1331,7 @@ public:
 
     [[noreturn]] _Fake_no_copy_callable_adapter(const _Fake_no_copy_callable_adapter& _Other)
         : _Storage(_STD move(_Other._Storage)) {
-        _CSTD abort(); // shouldn't be called
+        _STL_REPORT_ERROR("this callable object should not be copied"); // shouldn't be called
     }
 
     _Fake_no_copy_callable_adapter(_Fake_no_copy_callable_adapter&& _Other)          = default;
diff --git a/stl/inc/memory b/stl/inc/memory
@@ -1128,11 +1128,11 @@ private:
 #ifdef _M_CEE_PURE
     // permanent workaround to avoid mentioning _purecall in msvcurt.lib, ptrustu.lib, or other support libs
     virtual void _Destroy() noexcept {
-        _CSTD abort();
+        _STL_REPORT_ERROR("_Ref_count_base base class member functions should not be called");
     }
 
     virtual void _Delete_this() noexcept {
-        _CSTD abort();
+        _STL_REPORT_ERROR("_Ref_count_base base class member functions should not be called");
     }
 #else // ^^^ defined(_M_CEE_PURE) / !defined(_M_CEE_PURE) vvv
     virtual void _Destroy() noexcept     = 0; // destroy managed resource
diff --git a/stl/inc/utility b/stl/inc/utility
@@ -958,9 +958,6 @@ _NODISCARD constexpr underlying_type_t<_Ty> to_underlying(_Ty _Value) noexcept {
 
 _EXPORT_STD [[noreturn]] __forceinline void unreachable() noexcept /* strengthened */ {
     _STL_UNREACHABLE;
-#ifdef _DEBUG
-    _CSTD abort(); // likely to be called in debug mode, but can't be relied upon - already entered the UB territory
-#endif // defined(_DEBUG)
 }
 
 template <class _Ty, class _Uty,
diff --git a/stl/inc/xcall_once.h b/stl/inc/xcall_once.h
@@ -95,7 +95,7 @@ void(call_once)(once_flag& _Once, _Fn&& _Fx, _Args&&... _Ax)
     // parentheses against common "#define call_once(flag,func) pthread_once(flag,func)"
     int _Pending;
     if (!_RENAME_WINDOWS_API(__std_init_once_begin_initialize)(&_Once._Opaque, 0, &_Pending, nullptr)) {
-        _CSTD abort();
+        _STL_REPORT_ERROR("InitOnceBeginInitialize() failed");
     }
 
     if (_Pending != 0) {
diff --git a/stl/inc/xlocale b/stl/inc/xlocale
@@ -446,7 +446,7 @@ const _Facet& __CRTDECL use_facet(const locale& _Loc) { // get facet reference f
 #if _HAS_EXCEPTIONS
             _Throw_bad_cast(); // lazy disallowed
 #else
-            _CSTD abort(); // lazy disallowed
+            _STL_REPORT_ERROR("lazy facet disallowed");
 #endif
         } else { // queue up lazy facet for destruction
             auto _Pfmod = const_cast<locale::facet*>(_Psave);
diff --git a/stl/inc/xutility b/stl/inc/xutility
@@ -1121,7 +1121,8 @@ struct _Projected_impl {
 
         using value_type = remove_cvref_t<indirect_result_t<_Proj&, _It>>;
         [[noreturn]] indirect_result_t<_Proj&, _It> operator*() const {
-            _CSTD abort(); // shouldn't be called, see GH-3888
+            _STL_REPORT_ERROR("std::projected::operator*() can't be called (N5008 [projected]/1)");
+            _STL_UNREACHABLE; // no return value available for "continue on error"
         }
     };
 };
diff --git a/stl/inc/yvals.h b/stl/inc/yvals.h
@@ -253,7 +253,9 @@ _EMIT_STL_ERROR(STL1008, "_STL_CALL_ABORT_INSTEAD_OF_INVALID_PARAMETER has been
 #define _MSVC_STL_DOOM_FUNCTION(mesg) ::_invoke_watson(nullptr, nullptr, nullptr, 0, 0)
 #else // Use the MSVC __fastfail intrinsic:
 extern "C" __declspec(noreturn) void __fastfail(unsigned int); // declared by <intrin.h>
-#define _MSVC_STL_DOOM_FUNCTION(mesg) __fastfail(5) // __fastfail(FAST_FAIL_INVALID_ARG), value defined by <winnt.h>
+#define _MSVC_STL_DOOM_FUNCTION(mesg)                                                  \
+    __fastfail(5); /* __fastfail(FAST_FAIL_INVALID_ARG), value defined by <winnt.h> */ \
+    _STL_UNREACHABLE /* TRANSITION, DevCom-10914110 */
 #endif // choose "doom function"
 #endif // ^^^ !defined(_MSVC_STL_DOOM_FUNCTION) ^^^
 

Original file line number	Diff line number	Diff line change
`@@ -2990,7 +2990,8 @@ public:`
`2990`	`2990`	`break;`
`2991`	`2991`
`2992`	`2992`	`default: // Unrecognized bit pattern`
`2993`		`- _CSTD abort();`
	`2993`	`+ _STL_REPORT_ERROR("atomic shared_ptr invariant broken");`
	`2994`	`+ break;`
`2994`	`2995`	`}`
`2995`	`2996`	`}`
`2996`	`2997`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3540,7 +3540,7 @@ _NODISCARD _FormatContext::iterator _Tuple_formatter_format(const tuple<formatte`
`3540`	`3540`	`_STD _Tuple_formatter_format_to_context(`
`3541`	`3541`	`_Underlying, _Separator, _Opening_bracket, _Closing_bracket, _Tmp_ctx, _Args...);`
`3542`	`3542`	`} else {`
`3543`		`- _CSTD abort(); // no basic_format_context object other than _Default_format_context can be created`
	`3543`	`+ _STL_REPORT_ERROR("no basic_format_context object other than _Default_format_context can be created");`
`3544`	`3544`	`}`
`3545`	`3545`
`3546`	`3546`	`const int _Width = _STD _Measure_display_width<_CharT>(_Tmp_str);`
Original file line number	Diff line number	Diff line change
`@@ -1128,11 +1128,11 @@ private:`
`1128`	`1128`	`#ifdef _M_CEE_PURE`
`1129`	`1129`	`// permanent workaround to avoid mentioning _purecall in msvcurt.lib, ptrustu.lib, or other support libs`
`1130`	`1130`	`virtual void _Destroy() noexcept {`
`1131`		`- _CSTD abort();`
	`1131`	`+ _STL_REPORT_ERROR("_Ref_count_base base class member functions should not be called");`
`1132`	`1132`	`}`
`1133`	`1133`
`1134`	`1134`	`virtual void _Delete_this() noexcept {`
`1135`		`- _CSTD abort();`
	`1135`	`+ _STL_REPORT_ERROR("_Ref_count_base base class member functions should not be called");`
`1136`	`1136`	`}`
`1137`	`1137`	`#else // ^^^ defined(_M_CEE_PURE) / !defined(_M_CEE_PURE) vvv`
`1138`	`1138`	`virtual void _Destroy() noexcept = 0; // destroy managed resource`
Original file line number	Diff line number	Diff line change
`@@ -958,9 +958,6 @@ _NODISCARD constexpr underlying_type_t<_Ty> to_underlying(_Ty _Value) noexcept {`
`958`	`958`
`959`	`959`	`_EXPORT_STD [[noreturn]] __forceinline void unreachable() noexcept /* strengthened */ {`
`960`	`960`	`_STL_UNREACHABLE;`
`961`		`-#ifdef _DEBUG`
`962`		`- _CSTD abort(); // likely to be called in debug mode, but can't be relied upon - already entered the UB territory`
`963`		`-#endif // defined(_DEBUG)`
`964`	`961`	`}`
`965`	`962`
`966`	`963`	`template <class _Ty, class _Uty,`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ void(call_once)(once_flag& _Once, _Fn&& _Fx, _Args&&... _Ax)`
`95`	`95`	`// parentheses against common "#define call_once(flag,func) pthread_once(flag,func)"`
`96`	`96`	`int _Pending;`
`97`	`97`	`if (!_RENAME_WINDOWS_API(__std_init_once_begin_initialize)(&_Once._Opaque, 0, &_Pending, nullptr)) {`
`98`		`- _CSTD abort();`
	`98`	`+ _STL_REPORT_ERROR("InitOnceBeginInitialize() failed");`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`if (_Pending != 0) {`
Original file line number	Diff line number	Diff line change
`@@ -1121,7 +1121,8 @@ struct _Projected_impl {`
`1121`	`1121`
`1122`	`1122`	`using value_type = remove_cvref_t<indirect_result_t<_Proj&, _It>>;`
`1123`	`1123`	`[[noreturn]] indirect_result_t<_Proj&, _It> operator*() const {`
`1124`		`- _CSTD abort(); // shouldn't be called, see GH-3888`
	`1124`	`+ _STL_REPORT_ERROR("std::projected::operator*() can't be called (N5008 [projected]/1)");`
	`1125`	`+ _STL_UNREACHABLE; // no return value available for "continue on error"`
`1125`	`1126`	`}`
`1126`	`1127`	`};`
`1127`	`1128`	`};`