Fix atomic_ref::is_lock_free() on x64 (#4729)

StephanTLavavej · AlexGuteniev · web-flow · commit 14b54cab1bb0 · 2024-06-27T13:39:27.000-07:00
Co-authored-by: Alex Guteniev &lt;gutenev@gmail.com&gt;
diff --git a/stl/inc/atomic b/stl/inc/atomic
@@ -2370,8 +2370,10 @@ public:
 #else // ^^^ _ATOMIC_HAS_DCAS / !_ATOMIC_HAS_DCAS vvv
         if constexpr (is_always_lock_free) {
             return true;
-        } else {
+        } else if constexpr (_Is_potentially_lock_free) {
             return __std_atomic_has_cmpxchg16b() != 0;
+        } else {
+            return false;
         }
 #endif // ^^^ !_ATOMIC_HAS_DCAS ^^^
     }
diff --git a/tests/std/tests/P0019R8_atomic_ref/test.cpp b/tests/std/tests/P0019R8_atomic_ref/test.cpp
@@ -447,6 +447,22 @@ void test_gh_4472() {
     assert(ar.is_lock_free());
 }
 
+// GH-4728 "<atomic>: On x64, atomic_ref::is_lock_free() incorrectly returns true when it shouldn't"
+void test_gh_4728() {
+    struct Large {
+        char str[100]{};
+    };
+
+    alignas(std::atomic_ref<Large>::required_alignment) Large lg{};
+
+    static_assert(std::atomic_ref<Large>::required_alignment == alignof(Large));
+
+    static_assert(!std::atomic_ref<Large>::is_always_lock_free);
+
+    std::atomic_ref<Large> ar{lg};
+    assert(!ar.is_lock_free());
+}
+
 int main() {
     test_ops<false, char>();
     test_ops<false, signed char>();
@@ -500,6 +516,7 @@ int main() {
 
     test_gh_1497();
     test_gh_4472();
+    test_gh_4728();
 }
 
 #endif // ^^^ run test ^^^

Original file line number	Diff line number	Diff line change
`@@ -2370,8 +2370,10 @@ public:`
`2370`	`2370`	`#else // ^^^ _ATOMIC_HAS_DCAS / !_ATOMIC_HAS_DCAS vvv`
`2371`	`2371`	`if constexpr (is_always_lock_free) {`
`2372`	`2372`	`return true;`
`2373`		`- } else {`
	`2373`	`+ } else if constexpr (_Is_potentially_lock_free) {`
`2374`	`2374`	`return __std_atomic_has_cmpxchg16b() != 0;`
	`2375`	`+ } else {`
	`2376`	`+ return false;`
`2375`	`2377`	`}`
`2376`	`2378`	`#endif // ^^^ !_ATOMIC_HAS_DCAS ^^^`
`2377`	`2379`	`}`