You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make sure your changes are not breaking styles and lint rules, in the root project, run:
npm install
npm run quave-check
quave-check should not return any error or warning. If it does you need to fix them before sending a PR.
If you get an error because some npm modules are not resolved (import/no-unresolved) you need to run npm install inside the Meteor project that is throwing this error so you generate the node_modules folder for it.
We have a git hook to prevent commits that are not passing these rules but it's good to double-check as maybe your hooks set up can be messed up.
Making a Pull Request
Create a fork and make your changes on it.
Test your changes and make sure you sync your code changes (src folder) with your text changes (tutorial folder).
Build your changes:
npm run build
Create your Pull Request against master branch.
Sign the CLA.
Wait for feedback or approval.
About
React Tutorial is the best place to learn how to use React and Meteor together