| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 11:09:11 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=251.926396,conversation_content-fragment;desc="conversation_content fragment";dur=701.016711,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=218.390374,nginx;desc="NGINX";dur=0.756829,glb;desc="GLB";dur=101.397842
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=WKx0Xx1mNKIWIV1DMbtKwQuwQY1PlnC656Ozi9ICrwo1Iwvdh7MgYCygDH4I%2FgC9DBSIp6WY4Rb4GUUywhmnlIAb43eM6lfTHWtUpLuVpeyjkKWoa9whKmnqTeXgkcazTKJBCDuDuezpD9NsmVoEv6dINkneHSSGirjLhiC3ydbJEfIxjtCcLH5KpVNYWBe3sGC0bHJr%2FQhe1YkI9NNoftO0dLrASqtO7qRCcHHjAhhbD5NlsFP0Yge9cAWs0SGqD59kvkpEE4GVjHZ%2FpowmrQ%3D%3D--aI2BH3iBHIn40Wdz--0zlP0FlctAPVGspSvj2OnQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.248406885.1753528150; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 11:09:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 11:09:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C26E:1AFF47:4AB9D8:6253DB:6884B756
Tomcat8 Support by cyrille-leclerc · Pull Request #30 · magro/memcached-session-manager · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 350
Tomcat8 Support #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Tomcat8 Support #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t causes an error
… TestUtils.CONTEXT_PATH
…edForContainerProtectedResourceIsStoredInMemcached() is the last failing test
Closed
|
are you sure a 408 is returned? i got an test error "expected:<302> but was:<200>" |
|
I just ran the tests in tomcat8 and got |
|
I'll be on holidays for 2 weeks. I will continue to work on it in December. Cyrille |
|
@cyrille-leclerc enjoy! |
|
Looking again into this, I just saw that you stated directly in the PR text that testSessionCreatedForContainerProtectedResourceIsStoredInMemcached is still failing - sorry for missing that! :-) Looking into the issue and sources now... |
|
Thanks Martin, It's on my todo list but my "day job" is taking me of lot of hours these On Thu, Dec 19, 2013 at 12:51 AM, Martin Grotzke
Cyrille Le Clerc |
|
Just saw that you duplicated tests from core - probably because the conflict of Embedded vs. Tomcat? I'm just thinking about making test classes generic, and TestUtils and TomcatBuilder as well, so that tests can hold Tomcat or Embedded... |
…at instance. * Made TestUtils generic to return an appropriate TomcatBuilder. * Moved several tomcat access utils from TestUtils to TomcatBuilder. * Added EmbeddedTestUtils as replacement for former TestUtils * Removed duplicated tests from tomcat8 module. core, tomcat6 and tomcat7 modules are green, tomcat8 now fails with: Failed tests: testContextReload(de.javakaffee.web.msm.MemcachedSessionManagerIntegrationTC8Test): expected:<null> but was:<bar> testSerializeSessionFields(de.javakaffee.web.msm.TranscoderServiceTC8Test) testSerializeSessionFieldsIncludesFormPrincipalNote(de.javakaffee.web.msm.TranscoderServiceTC8Test) testSerializeSessionFieldsIncludesFormRequestNote(de.javakaffee.web.msm.TranscoderServiceTC8Test) testSerializeSessionFieldsWithAuthenticatedPrincipal(de.javakaffee.web.msm.TranscoderServiceTC8Test) testSerializeSessionWithAttributes(de.javakaffee.web.msm.TranscoderServiceTC8Test) testSerializeSessionWithoutAttributes(de.javakaffee.web.msm.TranscoderServiceTC8Test) testVersionUpgrade(de.javakaffee.web.msm.TranscoderServiceTC8Test) testSessionCreatedForContainerProtectedResourceIsStoredInMemcached(de.javakaffee.web.msm.integration.NonStickySessionsIntegrationTC8Test): expected:<true> but was:<false> testFormAuthDontCauseSessionStaleness(de.javakaffee.web.msm.integration.NonStickySessionsIntegrationTC8Test): expected:<true> but was:<false> testIgnoredResourcesWithFormAuthDontCauseSessionStaleness(de.javakaffee.web.msm.integration.NonStickySessionsIntegrationTC8Test): expected:<true> but was:<false> testSerializationOfAuthStuffWithFormAuth(de.javakaffee.web.msm.integration.TomcatFailoverIntegrationTC8Test): expected:<true> but was:<false> testSerializationOfAuthStuffWithFormAuth(de.javakaffee.web.msm.integration.TomcatFailoverIntegrationTC8Test): expected:<true> but was:<false>
|
TranscoderServiceTC8Test is fixed now (commit c88e5b0). |
|
Yes, let's use the tomcat8 branch. |
|
Hi @magro, here is a problem to make de.javakaffee.msm:memcached-session-manager compatible for tcat 6, 7 and 8: de.javakaffee.web.msm.CommitInterceptingActionHook uses Could I suggest to
|
|
IIRC the hook is no longer used at all, can you check this? |
"core" components incompatibles with Tomcat 8
My recommendation:
My recommendation: unknown for the moment "core" components to upgrade for Tomcat 8
My recommendation: replace the constants |
|
@cyrille-leclerc Thanx for your analysis!
|
|
Re contextHasFormBasedSecurityConstraint: this should probably be pulled into the SessionManager interface defined by MemcachedSessionService. |
…6. We use Tomcat 7 version in “core” to match the new artifact naming in maven repositories. 5 tests are still failing in tomcat8 branch, many of them are caused by an invalid app initialisation under Tomcat8.
|
There is a problem with form based authentication on Tomcat8: the |
…ad of "/login”. 1 test is still failing: ``` testSessionCreatedForContainerProtectedResourceIsStoredInMemcached(de.javakaffee.web.msm.integration.NonStickySessionsIntegrationTC8Test): id=CD88FE36E020759087DAB47489892C21-n1 expected:<302> but was:<200> ```
``` java.lang.AssertionError: IllegalState: 'POST /j_security_check' did not return a 302 but a 200, app is not properly initialized. Page content: id=CD43FCF5268AD1C110B5D1E7D7F7F0D2-n1 Expected :302 Actual :200 <Click to see difference> at org.testng.Assert.fail(Assert.java:86) at org.testng.Assert.failNotEquals(Assert.java:440) at org.testng.Assert.assertEquals(Assert.java:110) at org.testng.Assert.assertEquals(Assert.java:325) at de.javakaffee.web.msm.integration.NonStickySessionsIntegrationTest.testSessionCreatedForContainerProtectedResourceIsStoredInMemcached(NonStickySessionsIntegrationTest.java:943) at de.javakaffee.web.msm.integration.NonStickySessionsIntegrationTC8Test.testSessionCreatedForContainerProtectedResourceIsStoredInMemcached(NonStickySessionsIntegrationTC8Test.java:35) ``
magro
pushed a commit
that referenced
this pull request
Dec 24, 2013
Thanx @h0nIg (Hans-Joachim Kliemeck) and @cyrille-leclerc (Cyrille Le Clerc). See also pull requests #28 and #30 Tomcat8 now redirects with 303 instead of 302. For 303 httpclient automatically redirects, so httpclient must be asked not to do so, additionally the status code checks in TestUtils needed to be extended for 303. Change context path to "" to get rid of tomcat8 //login workaround
|
I fixed open issues (see commits in tomcat8 branch) and just merged it into master (squashed to 1 commit). Thanx for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
NonStickySessionsIntegrationTC8Test.testSessionCreatedForContainerProtectedResourceIsStoredInMemcached() is the last failing test.
It is caused by
o.a.c.a.FormAuthenticator.authenticate(Request, HttpServletResponse)that returns a408/HttpServletResponse.SC_REQUEST_TIMEOUTbecausesessionisnullandlandingPageisnull.