change some more logs

Erik Gomez · erikng · commit 019650db79b9 · 2024-08-01T07:52:05.000-05:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,8 +8,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 Requires macOS 12.0 and higher.
 
 ### Added
+- Device within the `nudgeMinorUpdateEventLaunchDelay` now show current and delayed date
+  - These logs also now show in the default Nudge logs when use the `logger` LaunchDaemon
+  - Addresses [625](https://github.com/macadmins/nudge/issues/625)
 
 ### Changed
+- Some logs have been changed from `info` to `error`, `warning` or `notice` to give admins more visibility into Nudge behaviors
 - The `board-id` property has been moved to a `debug` log event
   - Works around reports like [623](https://github.com/macadmins/nudge/issues/623)
 
diff --git a/Nudge/UI/Main.swift b/Nudge/UI/Main.swift
@@ -387,11 +387,11 @@ class AppDelegate: NSObject, NSApplicationDelegate {
                     center.add(request)
                     LogManager.info("Scheduled notification for terminated application \(applicationIdentifier)", logger: uiLog)
                 case .denied:
-                    LogManager.info("Notifications are denied; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)
+                    LogManager.error("Notifications are denied; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)
                 case .notDetermined:
-                    LogManager.info("Notification status not determined; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)
+                    LogManager.warning("Notification status not determined; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)
                 @unknown default:
-                    LogManager.info("Unknown notification status; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)
+                    LogManager.warning("Unknown notification status; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)
             }
         }
     }
@@ -783,7 +783,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
             LogManager.error("Failed to terminate application: \(application.bundleIdentifier ?? "")", logger: utilsLog)
             return
         }
-        LogManager.info("Successfully terminated application: \(application.bundleIdentifier ?? "")", logger: utilsLog)
+        LogManager.notice("Successfully terminated application: \(application.bundleIdentifier ?? "")", logger: utilsLog)
     }
 
     private func terminateApplications(afterInitialLaunch: Bool = false) {
diff --git a/Nudge/Utilities/Utils.swift b/Nudge/Utilities/Utils.swift
@@ -19,9 +19,9 @@ import SystemConfiguration
 struct AppStateManager {
     func activateNudge() {
         if OptionalFeatureVariables.honorFocusModes {
-            LogManager.info("honorFocusModes is configured - checking focus status. Warning: This feature may be unstable.", logger: utilsLog)
+            LogManager.notice("honorFocusModes is configured - checking focus status. Warning: This feature may be unstable.", logger: utilsLog)
             if isFocusModeEnabled() {
-                LogManager.info("Device has focus modes set - bypassing activation event", logger: utilsLog)
+                LogManager.notice("Device has focus modes set - bypassing activation event", logger: utilsLog)
                 return
             }
         }
@@ -96,7 +96,7 @@ struct AppStateManager {
 
         // Bail Nudge if within gracePeriodLaunchDelay
         if gracePeriodLaunchDelay > gracePeriodPathCreationTimeInHours {
-            LogManager.info("gracePeriodPath (\(gracePeriodPath)) within gracePeriodLaunchDelay (\(gracePeriodLaunchDelay)) - File age is \(gracePeriodPathCreationTimeInHours) hours", logger: uiLog)
+            LogManager.notice("gracePeriodPath (\(gracePeriodPath)) within gracePeriodLaunchDelay (\(gracePeriodLaunchDelay)) - File age is \(gracePeriodPathCreationTimeInHours) hours", logger: uiLog)
             nudgePrimaryState.shouldExit = true
             return currentDate
         } else {
@@ -106,7 +106,7 @@ struct AppStateManager {
         if gracePeriodInstallDelay > gracePeriodPathCreationTimeInHours {
             if currentDate > originalRequiredInstallationDate {
                 requiredInstallationDate = currentDate.addingTimeInterval(Double(gracePeriodsDelay) * 3600)
-                LogManager.info("Device permitted for gracePeriodInstallDelay - setting date from: \(originalRequiredInstallationDate) to: \(requiredInstallationDate)", logger: uiLog)
+                LogManager.notice("Device permitted for gracePeriodInstallDelay - setting date from: \(originalRequiredInstallationDate) to: \(requiredInstallationDate)", logger: uiLog)
                 return requiredInstallationDate
             }
         } else {

Original file line number	Diff line number	Diff line change
`@@ -387,11 +387,11 @@ class AppDelegate: NSObject, NSApplicationDelegate {`
`387`	`387`	`center.add(request)`
`388`	`388`	`LogManager.info("Scheduled notification for terminated application \(applicationIdentifier)", logger: uiLog)`
`389`	`389`	`case .denied:`
`390`		`- LogManager.info("Notifications are denied; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)`
	`390`	`+ LogManager.error("Notifications are denied; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)`
`391`	`391`	`case .notDetermined:`
`392`		`- LogManager.info("Notification status not determined; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)`
	`392`	`+ LogManager.warning("Notification status not determined; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)`
`393`	`393`	`@unknown default:`
`394`		`- LogManager.info("Unknown notification status; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)`
	`394`	`+ LogManager.warning("Unknown notification status; cannot schedule notification for \(applicationIdentifier)", logger: uiLog)`
`395`	`395`	`}`
`396`	`396`	`}`
`397`	`397`	`}`
`@@ -783,7 +783,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {`
`783`	`783`	`LogManager.error("Failed to terminate application: \(application.bundleIdentifier ?? "")", logger: utilsLog)`
`784`	`784`	`return`
`785`	`785`	`}`
`786`		`- LogManager.info("Successfully terminated application: \(application.bundleIdentifier ?? "")", logger: utilsLog)`
	`786`	`+ LogManager.notice("Successfully terminated application: \(application.bundleIdentifier ?? "")", logger: utilsLog)`
`787`	`787`	`}`
`788`	`788`
`789`	`789`	`private func terminateApplications(afterInitialLaunch: Bool = false) {`