You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule between master and branch should be different to take the PR reference in consideration when merging.
This PR should be fixing the current build failure on master due to the latest commit message fix: report launcher process error when exit event is not emitted (#3647) being more than 72 characters (https://travis-ci.org/github/karma-runner/karma/jobs/757457475).
Problem
The problem is that the same header-max-length rule is applied to master and the PR branches and when a PR branch is merged the commit message has the PR reference appended to it making the length longer and potentially breaking the commitlint on master
Proposed Solution
Using different header-max-length rules for master and branches.
header-max-length rule on master set to 80 characters to temporary fix the build on master and then submit another PR to set the header-max-length rule on master set to 72 characters.
header-max-length rule on branches set to 64 characters (72 - 8 characters for the PR reference)
Hm, maybe it is better to simply disable commit message validation on master? 🤔
@devoto13 yes we could do that but do you mean permanently? If we are happy with having no commitlint running on master then we can just disable it (I can submit another PR) ... otherwise we do need this PR to have different header-max-length rules.
Yes, permanently. If you think about it, the check is not really actionable: one can't revert or fix the commit in master branch. So we can only run it in PRs/branches where we can prevent a bad commit message. But it's just my opinion. It's up to @johnjbarton to decide which approach to use.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule between master and branch should be different to take the PR reference in consideration when merging.
This PR should be fixing the current build failure on master due to the latest commit message
fix: report launcher process error when exit event is not emitted (#3647)
being more than 72 characters (https://travis-ci.org/github/karma-runner/karma/jobs/757457475).Problem
The problem is that the same
header-max-length
rule is applied to master and the PR branches and when a PR branch is merged the commit message has the PR reference appended to it making the length longer and potentially breaking thecommitlint
on masterProposed Solution
Using different
header-max-length
rules for master and branches.header-max-length
rule on master set to 80 characters to temporary fix the build on master and then submit another PR to set the header-max-length rule on master set to 72 characters.header-max-length
rule on branches set to 64 characters (72 - 8 characters for the PR reference)