| CARVIEW |
Select Language
HTTP/2 302
date: Thu, 09 Oct 2025 21:37:53 GMT
content-length: 0
location: https://github.com/karma-runner/karma/pull/3527
server-timing: nginx;desc="NGINX";dur=1.101644,glb;desc="GLB";dur=136.211611
x-voltron-version: 266d7a9
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=Zgjxv%2BBzIqFO9kIfzKUDsXWus88bCrqGqqSzBkArj9xg3THJByAwU6HU%2B348jtZ1LiaJ0j%2BMd7%2F1Licnzxr7Ja9TsXGrCHeQyqRvSJyfrMzuGdpSCJchtmcZs0l3b%2BGPrjWL7X7XaHH9mC2yTNqbpaO3p0nB3EG3XW%2BQuNOvdJ99GIy8KvpgCyfNkS5mzaMuCXa7BBMILvbsB0LCrWsCKq7e%2F2HBVD87B9BKW5oKd27fWWlYTqpvg%2B4BODkwNWCUDv261gFZy510DpPXRgNUyQ%3D%3D--wGwapYm6cXR1y7Nr--8VILkxqzhEH1K8MYYClUuQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1750334201.1760045873; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 21:37:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 21:37:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B87A:93457:F6F253:1244269:68E82B31
HTTP/2 200
date: Thu, 09 Oct 2025 21:37:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=317.535699,conversation_content-fragment;desc="conversation_content fragment";dur=1442.392643,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=342.396505,nginx;desc="NGINX";dur=1.387553,glb;desc="GLB";dur=136.629459
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B87A:93457:F6F273:1244299:68E82B31
fix(proxy): use keepAlive agent by matz3 · Pull Request #3527 · karma-runner/karma · GitHub
matz3
force-pushed
the
proxy-keepAlive-agent
branch
from
June 10, 2020 06:42
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(proxy): use keepAlive agent #3527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 2701 completed (commit 6fa29d34f5 by @matz3) |
devoto13
reviewed
May 25, 2020
|
✅ Build karma 302 completed (commit 6fa29d34f5 by @matz3) |
|
✅ Build karma 303 completed (commit 6fa29d34f5 by @matz3) |
|
✅ Build karma 304 completed (commit e2978de21f by @matz3) |
|
✅ Build karma 2702 completed (commit d60c75b060 by @matz3) |
|
✅ Build karma 303 completed (commit d60c75b060 by @matz3) |
|
✅ Build karma 2703 completed (commit cdae43add2 by @matz3) |
|
✅ Build karma 304 completed (commit 94fb88eaf0 by @matz3) |
|
✅ Build karma 305 completed (commit cdae43add2 by @matz3) |
devoto13
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
We already have a E2E test for HTTP proxy here. Ideally we would want to test that proxy connections are re-used, but it may be tricky to implement such test. It should be enough to test that feature itself works correctly + a unit test to verify that correct agent is used.
nit: Consider squashing commits and changing commit to "feat(proxy): ..." as this was not broken before, this is a new feature.
Using an agent with keepAlive improves performance as the socket is reused across multiple requests.
matz3
force-pushed
the
proxy-keepAlive-agent
branch
from
f25edeb to
7e4df8a
Compare
|
Thanks for your review! I've squashed the commits and adopted the message. |
|
✅ Build karma 2709 completed (commit ac23b439bb by @matz3) |
|
✅ Build karma 311 completed (commit ac23b439bb by @matz3) |
|
✅ Build karma 310 completed (commit ac23b439bb by @matz3) |
karmarunnerbot
pushed a commit
that referenced
this pull request
Jun 11, 2020
# [5.1.0](v5.0.9...v5.1.0) (2020-06-11) ### Features * **proxy:** use keepAlive agent ([#3527](#3527)) ([b77f94c](b77f94c))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
Using an agent with keepAlive improves performance as the socket is reused across multiple requests.
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
# [5.1.0](karma-runner/karma@v5.0.9...v5.1.0) (2020-06-11) ### Features * **proxy:** use keepAlive agent ([karma-runner#3527](karma-runner#3527)) ([b77f94c](karma-runner@b77f94c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Using an agent with keepAlive improves performance as the socket is
reused across multiple requests.