You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I would like to understand the motivation better: this changes behavior in the case that result has zero length. We don't refresh the timer for example.
@johnjbarton I'm pretty sure this will not have unintended side effects. The only case which behaves differently is when result is [] (empty array). Before it would end up emitting spec_complete with [], but the handler expects a single result object and will crash as [].suite is undefined.
[] will not refresh a no activity timeout, but it should not really matter as client does not send [] at the moment and this change is just to add extra safety to avoid a potential crash.
Let me know if you still want me to remove the return, so no activity timeout is refreshed in this case?
## [5.0.4](v5.0.3...v5.0.4) (2020-04-30)
### Bug Fixes
* **browser:** make sure that empty results array is still recognized ([#3486](#3486)) ([fa95fa3](fa95fa3))
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise empty array is treated as a single value, which causes issues down the road.