You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe we can replace That is 6.x, 8.x and 10.x at this point. with something that acknowledges the version dependency. You may need to install older versions of karma-runner if you must support older versions of nodejs. For example, to run on nodejs 6.x, install karma-runner 3.x. Then in future we can just leave this doc file as is.
Yeah, it would be nice to update this documentation line - do you have proposition for whole section ? Because currently it contains Karma works on all LTS versions , which would not be true after this pull request merge.
Karma works on all LTS versions node in active maintenance state (see LTS docs for more info) as well as the latest stable version. That is 6.x, 8.x and 10.x at this point.
to eg:
Karma is tested on (at least) the active LTS versions of node as specified by the Node.js Release Working Group. The nodejs version numbers are set in the package.json. Older versions of karma work with older versions of nodejs, but these older versions are not maintained or updated.
Set node 8 as minimal supported version.
Closes#3151
BREAKING CHANGE:
Drop Support for Node 6, to make it possible to use async/await in karma codebase.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lusarz
changed the title
This pull request remove support for node v6.
Let me know if I missed something here ...