| CARVIEW |
Select Language
HTTP/2 302
date: Thu, 09 Oct 2025 17:29:06 GMT
content-length: 0
location: https://github.com/karma-runner/karma/pull/3220
server-timing: nginx;desc="NGINX";dur=0.69627,glb;desc="GLB";dur=136.698386
x-voltron-version: 266d7a9
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=N0n9BlUrKhMdEfOXdSStc2gXv%2BP2CT%2FY9lTb0p2C6Qsq2A6GOV8TalTNSeYtF8uIiKx4So4RGvYI39djs6%2Bfdj%2F9V843lcKoHqX15Cg6HwW9K2sL5LDILDYaMsI4aEemLCFN9Fe%2FcjU20f95pPq5D1VeT%2BYiPtMgOW0XlwC%2BE%2Buc4fHLwICTZPu8TaWkjyNLt7OP8V%2B13FnPhL2Ajj6M9kkDoTeEFaa6URRoUENRXVxHq1vzLYH91JHU1N3FvKUST9ECq8exOnkySgJ0u2EU4A%3D%3D--KFebmcGN9cCQNzHW--ftKN%2Fq7bDM5XAmSoOFNrEA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.593744711.1760030945; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 17:29:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 17:29:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BFB6:23EB94:F31175:11EED1B:68E7F0E1
HTTP/2 200
date: Thu, 09 Oct 2025 17:29:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=347.459656,conversation_content-fragment;desc="conversation_content fragment";dur=1343.53446,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=272.123154,nginx;desc="NGINX";dur=1.114219,glb;desc="GLB";dur=136.47418
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: BFB6:23EB94:F311DB:11EED87:68E7F0E1
fix(server): use flatted for json.stringify by johnjbarton · Pull Request #3220 · karma-runner/karma · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(server): use flatted for json.stringify #3220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusarz
reviewed
Nov 26, 2018
lib/server.js
Outdated
| const tmp = require('tmp') | ||
| const fs = require('fs') | ||
| const path = require('path') | ||
| const {stringify} = require('flatted/cjs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to wrap this dependency into JSONUtils and add unit tests for it, something like we have with sha1 calculation ?
I like this kind of wrapping because of two reasons:
- dependencies sometimes change theirs APIs and behaviour - with wrapper covered by unit tests we're able to figure it out very early
- it's easier to remove dependency in future when it's used in single place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
lusarz
reviewed
Nov 27, 2018
test/unit/utils/json-utils.spec.js
Outdated
|
|
||
| const JsonUtils = require('../../../lib/utils/json-utils') | ||
|
|
||
| describe('Utils', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add one test that covers circular structure issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Remove json3 dep and use, probably was needed for older node code. Fixes karma-runner#3215
lusarz
approved these changes
Nov 27, 2018
|
@johnjbarton I see this made it to master, any idea of when a release will be cut with this feature? The circular json error this fixes is blocking angular 7 workflows from using karma |
|
As a temporary solution it's possible to set dependency as github branch link. This article may be useful in this context : https://medium.com/@jonchurch/use-github-branch-as-dependency-in-package-json-5eb609c81f1a |
|
@lusarz thanks for the link, that is definitely helpful to unblock some of my side projects. I'm hesitant to use that method for a prod system however, EDIT: Just saw v3.1.3, thanks you guys! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Remove json3 dep and use, probably was needed for older node code.
Fixes #3215