You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line throws TypeError: Converting circular structure to JSON and there's no way to disable it, even though the config that's used it perfectly valid.
This line throws `TypeError: Converting circular structure to JSON` and there's no way to disable it, even though the config that's used it perfectly valid.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The reason will be displayed to describe this comment to others. Learn more.
Configuration errors are common and the config can be changed dynamically by plugins. Logging the final config is a critical step in debugging user issues.
You could:
Find a way to log the config without json.stringify.
Wrap the stringify line with try/catch and log a debug message that the attempt to log the config failed.
Either way, wrapping the code in a check on the logLevel === debug would be great.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line throws
TypeError: Converting circular structure to JSON
and there's no way to disable it, even though the config that's used it perfectly valid.Check that your description matches the automatic change-log format:
https://karma-runner.github.io/latest/dev/git-commit-msg.html
then delete this reminder.